From: Jonathan Wakely <jwakely@redhat.com>
To: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: "Jonathan Wakely via Gcc-patches" <gcc-patches@gcc.gnu.org>,
"Jonathan Wakely" <jwakely.gcc@gmail.com>,
"Arsen Arsenović" <arsen@aarsen.me>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories
Date: Mon, 14 Nov 2022 10:16:50 +0000 [thread overview]
Message-ID: <CACb0b4mxgeanq6Mnkm1NovM2_vEkb=0XTYJxqH99eB8kLM96+g@mail.gmail.com> (raw)
In-Reply-To: <20221113212952.66bbe897@nbbrfq>
On Sun, 13 Nov 2022 at 20:30, Bernhard Reutner-Fischer via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
>
> On Sun, 13 Nov 2022 19:42:52 +0000
> Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> > On Sun, 13 Nov 2022, 18:06 Arsen Arsenović via Libstdc++, <
> > libstdc++@gcc.gnu.org> wrote:
> >
> > > I'm unsure why this issue only started manifesting now with how old this
> > > code is, but this should fix it.
> > >
> >
> > I just pushed a change to how the debug build makefiles are generated,
> > which presumably uncovered this latent bug. I'll review the patch in the
> > morning.
>
> Ah, you removed debugdir everywhere but in the install-debug rule :)
Doh! I'll get your fix below committed in a few minutes, thanks.
> I.e.:
>
> $ git diff
> diff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am
> index b545ebf0dcf..bfa031ea395 100644
> --- a/libstdc++-v3/src/Makefile.am
> +++ b/libstdc++-v3/src/Makefile.am
> @@ -422,5 +422,5 @@ build-debug: stamp-debug $(debug_backtrace_supported_h)
>
> # Install debug library.
> install-debug: build-debug
> - (cd ${debugdir} && $(MAKE) CXXFLAGS='$(DEBUG_FLAGS)' \
> - toolexeclibdir=$(glibcxx_toolexeclibdir)/debug install) ;
> + $(MAKE) -C debug CXXFLAGS='$(DEBUG_FLAGS)' \
> + toolexeclibdir=$(glibcxx_toolexeclibdir)/debug install
> diff --git a/libstdc++-v3/src/Makefile.in b/libstdc++-v3/src/Makefile.in
> index f54ee282fb0..8479d297389 100644
> --- a/libstdc++-v3/src/Makefile.in
> +++ b/libstdc++-v3/src/Makefile.in
> @@ -1142,8 +1142,8 @@ build-debug: stamp-debug $(debug_backtrace_supported_h)
>
> # Install debug library.
> install-debug: build-debug
> - (cd ${debugdir} && $(MAKE) CXXFLAGS='$(DEBUG_FLAGS)' \
> - toolexeclibdir=$(glibcxx_toolexeclibdir)/debug install) ;
> + $(MAKE) -C debug CXXFLAGS='$(DEBUG_FLAGS)' \
> + toolexeclibdir=$(glibcxx_toolexeclibdir)/debug install
>
> # Tell versions [3.59,3.63) of GNU make to not export all variables.
> # Otherwise a system limit (for SysV at least) may be exceeded.
>
> I personally did not experience the gdb.py install bug Arsen seems to
> have encountered though.
>
> thanks!
> >
> >
> >
> > > libstdc++-v3/ChangeLog:
> > >
> > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA
> > > when installing gdb scripts.
> > > * python/Makefile.in: Regenerate.
> > > ---
> > > Hi,
> > >
> > > Someone spotted on IRC spotted an error: if trying to install to a fresh
> > > prefix/sysroot with --enable-libstdcxx-debug, the install fails since it's
> > > intended target directories don't exist. I could replicate this on
> > > r13-3944-g43435c7eb0ff60 using
> > >
> > > $ ../gcc/configure --disable-bootstrap \
> > > --enable-libstdcxx-debug \
> > > --enable-languages=c,c++ \
> > > --prefix=$(pwd)/pfx
>
next prev parent reply other threads:[~2022-11-14 10:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 18:05 Arsen Arsenović
2022-11-13 19:42 ` Jonathan Wakely
2022-11-13 20:29 ` Bernhard Reutner-Fischer
2022-11-14 10:16 ` Jonathan Wakely [this message]
2022-11-14 10:29 ` Jonathan Wakely
2022-11-14 10:39 ` Jonathan Wakely
2022-11-14 13:15 ` Arsen Arsenović
2022-11-14 14:13 ` Jonathan Wakely
2022-11-14 14:19 ` Jonathan Wakely
2022-11-14 15:56 ` Arsen Arsenović
2022-11-14 16:00 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4mxgeanq6Mnkm1NovM2_vEkb=0XTYJxqH99eB8kLM96+g@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=arsen@aarsen.me \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).