Re: [PATCH] libstdc++: implement locale support for AIX

[David Edelsohn <dje.gcc@gmail.com>]

On Tue, Jan 12, 2021 at 12:41 PM Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>
> Hi Jonathan,
>
> >> On 12/01/21 15:14 +0000, CHIGOT, CLEMENT wrote:
> >>>Hi everyone,Â
> >>>
> >>>I've reworked the patch to merged dragonfly and AIX
> >>>models into the new one named "ieee_1003.1-2008".Â
> >>>It seems okay on the AIX part but if someone can test
> >>>on Dragonfly and Freebsd I would be glad. Configure
> >>>needs to be regenerated, first.
> >>
> >> Presumably it could also be tested on GNU/Linux and Solaris, since
> >> they implement the POSIX 2008 APIs needed.
> >
> > I'll give the patch a whirl on Solaris.  However, we will need to
> > distinguish between 11.3 (which is XPG6 only) and 11.4 (which support
> > XPG7).
>
> as almost expected, a build on Solaris 11.4 failed miserably due to the
> use of the various BSD extensions (localeconv_l, mbstowcs_l, strtod_l,
> strtof_l, strtold_l, wcsftime_l), whose use or fallback implementations
> are currently guarded by _AIX.  Should those be used in a directory
> supposed to conform to POSIX.1-2008 at all?  OTOH, almost duplicating
> the code into a separate bsd (or whatever, it's certainly not only
> DragonflyBSD) directory for this sole reason would be a shame.

Hi, Rainer

Thanks for testing.

I agree that #ifdef's are not the correct approach, but, if you enable
the fallbacks for Solaris, does everything then work?  Are those
fallbacks portable and we solely need a better mechanism to enable
them on platforms that require them?

Thanks, David