From: "CHIGOT, CLEMENT" <clement.chigot@atos.net>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: Jonathan Wakely <jwakely@redhat.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
David Edelsohn via Gcc-patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] libstdc++: implement locale support for AIX
Date: Wed, 27 Jan 2021 14:44:50 +0000 [thread overview]
Message-ID: <PA4PR02MB6686E3AC32B95250C52C563BEABB0@PA4PR02MB6686.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <yddr1m65ude.fsf@CeBiTec.Uni-Bielefeld.DE>
> * There are minor formatting issues:
>
> Should the linebreak in the extern inline definitions of strtof_l be
> after the return type, not before, matching GNU coding standards? It
> may well be that the C++ style is different, though.
>
> Unrelated whitespace changes in xpg7/ctype_members.cc
I haven't yet check all the format issues. Especially, because the previous
code was already wrongly formatted at some point. I'll do that when
releasing a "final" version of the patch.
> * The changes in the copyright ranges need to be undone, given that this
> is just a renamed/augmented version of the previous dragonfly code.
Ok, I wasn't sure about that. I'll revert.
> * Seeing the __DragonFly__ || __FreeBSD__ again, I had a quick look at
> the FreeBSD 12.2 headers and found that localeconv_l does take a
> locale_t arg, just like uselocale. DragonFlyBSD seems to be the same
> according to their online manuals. I expect to give the code a try in
> a FreeBSD 12.2 VM at some point to check.
Actually, it seems that the problem isn't about input argument, but
the output which should "int*".
> * While you now define _GLIBCXX_C_LOCALE_XPG7 in
> config/locale/xpg7/c_locale.h, config/os/aix/ctype_configure_char.cc
> still tests the previous _GLIBCXX_C_LOCALE_IEEE_2008.
Arf, I've missed that. it might not be the last patch then.
(I've made so much versions of it as I've tried to backport it to our
old versions. It seems that I've mixed up things...)
next prev parent reply other threads:[~2021-01-27 14:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PA4PR02MB6686075C6C254E583B72BC2AEAAB0@PA4PR02MB6686.eurprd02.prod.outlook.com>
[not found] ` <CAGWvny=XpcWGnyb=MWg5ziYSND7O1AnQ6-NAX811p1b5urH0YA@mail.gmail.com>
2021-01-11 15:35 ` Rainer Orth
2021-01-11 15:40 ` Jonathan Wakely
2021-01-11 15:56 ` CHIGOT, CLEMENT
2021-01-11 22:20 ` David Edelsohn
2021-01-12 15:14 ` CHIGOT, CLEMENT
2021-01-12 15:23 ` CHIGOT, CLEMENT
2021-01-12 15:25 ` Jonathan Wakely
2021-01-12 15:40 ` CHIGOT, CLEMENT
2021-01-12 15:44 ` David Edelsohn
2021-01-12 17:34 ` Jonathan Wakely
2021-01-12 15:52 ` Rainer Orth
2021-01-12 17:41 ` Rainer Orth
2021-01-12 17:44 ` David Edelsohn
2021-01-12 19:58 ` Rainer Orth
2021-01-13 11:57 ` Rainer Orth
2021-01-13 12:23 ` CHIGOT, CLEMENT
2021-01-13 12:31 ` Rainer Orth
2021-01-13 12:41 ` CHIGOT, CLEMENT
2021-01-13 12:47 ` Rainer Orth
2021-01-21 12:48 ` CHIGOT, CLEMENT
2021-01-21 16:36 ` Rainer Orth
2021-01-22 9:57 ` CHIGOT, CLEMENT
2021-01-22 11:04 ` Rainer Orth
2021-01-22 11:29 ` Jonathan Wakely
2021-01-22 11:54 ` Rainer Orth
2021-01-22 12:23 ` CHIGOT, CLEMENT
2021-01-27 12:52 ` CHIGOT, CLEMENT
2021-01-27 14:26 ` Rainer Orth
2021-01-27 14:44 ` CHIGOT, CLEMENT [this message]
2021-01-28 10:09 ` CHIGOT, CLEMENT
2021-05-17 9:17 ` CHIGOT, CLEMENT
2021-06-08 6:59 ` CHIGOT, CLEMENT
2021-06-09 14:50 ` Rainer Orth
2021-07-21 12:00 ` CHIGOT, CLEMENT
2021-07-21 13:04 ` Rainer Orth
2021-07-22 12:09 ` CHIGOT, CLEMENT
2021-07-22 12:19 ` Rainer Orth
2021-07-30 14:02 ` CHIGOT, CLEMENT
2022-03-16 9:57 ` CHIGOT, CLEMENT
2021-01-22 11:12 ` Jonathan Wakely
2021-01-22 11:02 ` Jonathan Wakely
2021-01-12 16:00 ` Rainer Orth
[not found] ` <PA4PR02MB6686C2022E2B42D82DC9F269EAAB0@PA4PR02MB6686.eurprd02.prod.outlook.com>
2021-01-11 15:38 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR02MB6686E3AC32B95250C52C563BEABB0@PA4PR02MB6686.eurprd02.prod.outlook.com \
--to=clement.chigot@atos.net \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).