public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: meyering@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/toollib.c Date: Tue, 11 Sep 2007 20:12:00 -0000 [thread overview] Message-ID: <20070911201254.13001.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: meyering@sourceware.org 2007-09-11 20:12:54 Modified files: . : WHATS_NEW tools : toollib.c Log message: Diagnose invalid PE values given on the pvmove command line (64-bit systems). * tools/toollib.c (xstrtouint32): New function. (_parse_pes): Use xstrtouint32; don't cast strtoul's unsigned long to uint32_t. Detect overflow. Author: Jim Meyering <jim@meyering.net> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.704&r2=1.705 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.105&r2=1.106 --- LVM2/WHATS_NEW 2007/09/11 13:49:51 1.704 +++ LVM2/WHATS_NEW 2007/09/11 20:12:54 1.705 @@ -1,5 +1,6 @@ Version 2.02.29 - ================================== + Diagnose invalid PE values given on the pvmove command line (64-bit systems). Include strerror string in dev_open_flags' stat failure message. Move guts of pvresize into library. Avoid error when --corelog is provided without --mirrorlog. (2.02.28) --- LVM2/tools/toollib.c 2007/08/22 14:38:18 1.105 +++ LVM2/tools/toollib.c 2007/09/11 20:12:54 1.106 @@ -911,6 +911,18 @@ return 1; } +static int xstrtouint32(const char *s, char **p, int base, uint32_t *result) +{ + unsigned long ul; + + errno = 0; + ul = strtoul(s, p, base); + if (errno || *p == s || (uint32_t) ul != ul) + return -1; + *result = ul; + return 0; +} + static int _parse_pes(struct dm_pool *mem, char *c, struct list *pe_ranges, const char *pvname, uint32_t size) { @@ -942,8 +954,7 @@ /* Start extent given? */ if (isdigit(*c)) { - start = (uint32_t) strtoul(c, &endptr, 10); - if (endptr == c) + if (xstrtouint32(c, &endptr, 10, &start)) goto error; c = endptr; /* Just one number given? */ @@ -954,8 +965,7 @@ if (*c == '-') { c++; if (isdigit(*c)) { - end = (uint32_t) strtoul(c, &endptr, 10); - if (endptr == c) + if (xstrtouint32(c, &endptr, 10, &end)) goto error; c = endptr; }
next reply other threads:[~2007-09-11 20:12 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-09-11 20:12 meyering [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-25 21:52 zkabelac 2011-11-18 19:19 zkabelac 2011-02-18 15:02 zkabelac 2010-11-23 20:39 zkabelac 2010-05-21 14:15 zkabelac 2010-05-21 14:11 zkabelac 2010-05-21 12:19 zkabelac 2010-04-14 2:19 agk 2009-11-24 16:13 mbroz 2009-09-29 20:33 agk 2009-08-24 11:37 mbroz 2009-07-21 11:10 agk 2009-05-27 13:23 agk 2009-04-10 9:54 mbroz 2008-06-10 15:25 wysochanski 2008-02-06 16:09 agk 2008-01-03 19:03 agk 2007-07-10 17:51 agk 2006-10-24 18:25 agk 2006-06-14 20:27 agk 2004-05-20 16:18 agk 2004-05-05 18:31 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070911201254.13001.qmail@sourceware.org \ --to=meyering@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).