public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/toollib.c
Date: Tue, 23 Nov 2010 20:39:00 -0000 [thread overview]
Message-ID: <20101123203915.11523.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-11-23 20:39:14
Modified files:
. : WHATS_NEW
tools : toollib.c
Log message:
Move arg_vgnames from local scope
As gcc puts probably all vars on stack this bug was not noticed in runtime.
Patch fixes referencing local scope list variable.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1804&r2=1.1805
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.213&r2=1.214
--- LVM2/WHATS_NEW 2010/11/23 18:29:06 1.1804
+++ LVM2/WHATS_NEW 2010/11/23 20:39:13 1.1805
@@ -1,5 +1,6 @@
Version 2.02.78 -
====================================
+ Fix out-of-scope variable usage in process_each_lv().
Fix dm_task_destroy(NULL) call in _node_clear_table() error path.
Fix resource leak in _rm_blks().
Suppress 'No PV label' message when removing several PVs without mdas.
--- LVM2/tools/toollib.c 2010/11/23 01:56:02 1.213
+++ LVM2/tools/toollib.c 2010/11/23 20:39:14 1.214
@@ -198,6 +198,7 @@
struct dm_list failed_lvnames;
struct dm_list tags, lvnames;
struct dm_list arg_lvnames; /* Cmdline vgname or vgname/lvname */
+ struct dm_list arg_vgnames;
char *vglv;
size_t vglv_sz;
@@ -208,8 +209,6 @@
dm_list_init(&failed_lvnames);
if (argc) {
- struct dm_list arg_vgnames;
-
log_verbose("Using logical volume(s) on command line");
dm_list_init(&arg_vgnames);
next reply other threads:[~2010-11-23 20:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 20:39 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 21:52 zkabelac
2011-11-18 19:19 zkabelac
2011-02-18 15:02 zkabelac
2010-05-21 14:15 zkabelac
2010-05-21 14:11 zkabelac
2010-05-21 12:19 zkabelac
2010-04-14 2:19 agk
2009-11-24 16:13 mbroz
2009-09-29 20:33 agk
2009-08-24 11:37 mbroz
2009-07-21 11:10 agk
2009-05-27 13:23 agk
2009-04-10 9:54 mbroz
2008-06-10 15:25 wysochanski
2008-02-06 16:09 agk
2008-01-03 19:03 agk
2007-09-11 20:12 meyering
2007-07-10 17:51 agk
2006-10-24 18:25 agk
2006-06-14 20:27 agk
2004-05-20 16:18 agk
2004-05-05 18:31 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123203915.11523.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).