public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/toollib.c Date: Fri, 18 Nov 2011 19:19:00 -0000 [thread overview] Message-ID: <20111118191923.15328.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-11-18 19:19:23 Modified files: . : WHATS_NEW tools : toollib.c Log message: Skip non-virtual snapshots for availability Change the behavior of availability change. With this patch the lvgchange returns success when VG is properly changed. It skips non-virtual origins from being changes when only 'vg' is specified as lvchange -a parameter. Before this change we had this: $> lvs -a LV VG Attr LSize Pool Origin lvol0 mvg owi-a-s- 128.00k lvol1 mvg owi-a-s- 128.00k lvol2 mvg swi-a-s- 1.25m lvol0 lvol3 mvg swi-a-s- 1.25m lvol1 $> lvchange -an mvg ; echo $? Can't change snapshot logical volume "lvol2". Can't change snapshot logical volume "lvol3". 5 $> lvs -a LV VG Attr LSize Pool Origin lvol0 mvg owi---s- 128.00k lvol1 mvg owi---s- 128.00k lvol2 mvg swi---s- 1.25m lvol0 lvol3 mvg swi---s- 1.25m lvol1 $> lvchange -ay mvg ; echo $? Can't change snapshot logical volume "lvol2". Can't change snapshot logical volume "lvol3". 5 $> lvs LV VG Attr LSize Pool Origin lvol0 mvg owi-a-s- 128.00k lvol1 mvg owi-a-s- 128.00k lvol2 mvg swi-a-s- 1.25m lvol0 lvol3 mvg swi-a-s- 1.25m lvol1 After commit: $> lvs -a LV VG Attr LSize Pool Origin lvol0 mvg owi-a-s- 128.00k lvol1 mvg owi-a-s- 128.00k lvol2 mvg swi-a-s- 1.25m lvol0 lvol3 mvg swi-a-s- 1.25m lvol1 $> lvchange -an mvg ; echo $? 0 $> lvs -a LV VG Attr LSize Pool Origin lvol0 mvg owi---s- 128.00k lvol1 mvg owi---s- 128.00k lvol2 mvg swi---s- 1.25m lvol0 lvol3 mvg swi---s- 1.25m lvol1 $> lvchange -ay mvg ; echo $? 0 $> lvs -a LV VG Attr LSize Pool Origin lvol0 mvg owi-a-s- 128.00k lvol1 mvg owi-a-s- 128.00k lvol2 mvg swi-a-s- 1.25m lvol0 lvol3 mvg swi-a-s- 1.25m lvol1 Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2186&r2=1.2187 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.235&r2=1.236 --- LVM2/WHATS_NEW 2011/11/15 17:32:12 1.2186 +++ LVM2/WHATS_NEW 2011/11/18 19:19:22 1.2187 @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Skip non-virtual origins for availability change for lvchange. Adjusted mirror region size only for mirrors and raids. Reorder prompt conditions for removal of active volumes. Avoid 'mda inconsistency' by properly registering UNLABELLED_PV flag (2.02.86). --- LVM2/tools/toollib.c 2011/11/12 22:44:11 1.235 +++ LVM2/tools/toollib.c 2011/11/18 19:19:22 1.236 @@ -123,6 +123,12 @@ if (lvl->lv->status & SNAPSHOT) continue; + /* Skip availability change for non-virt snaps when processing all LVs */ + /* FIXME: pass process_all to process_single_lv() */ + if (process_all && arg_count(cmd, available_ARG) && + lv_is_cow(lvl->lv) && !lv_is_virtual_origin(origin_from_cow(lvl->lv))) + continue; + if (lv_is_virtual_origin(lvl->lv) && !arg_count(cmd, all_ARG)) continue;
next reply other threads:[~2011-11-18 19:19 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-11-18 19:19 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-25 21:52 zkabelac 2011-02-18 15:02 zkabelac 2010-11-23 20:39 zkabelac 2010-05-21 14:15 zkabelac 2010-05-21 14:11 zkabelac 2010-05-21 12:19 zkabelac 2010-04-14 2:19 agk 2009-11-24 16:13 mbroz 2009-09-29 20:33 agk 2009-08-24 11:37 mbroz 2009-07-21 11:10 agk 2009-05-27 13:23 agk 2009-04-10 9:54 mbroz 2008-06-10 15:25 wysochanski 2008-02-06 16:09 agk 2008-01-03 19:03 agk 2007-09-11 20:12 meyering 2007-07-10 17:51 agk 2006-10-24 18:25 agk 2006-06-14 20:27 agk 2004-05-20 16:18 agk 2004-05-05 18:31 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20111118191923.15328.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).