public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/toollib.c Date: Fri, 18 Feb 2011 15:02:00 -0000 [thread overview] Message-ID: <20110218150226.11654.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-02-18 15:02:26 Modified files: . : WHATS_NEW tools : toollib.c Log message: Add some backtraces for error paths in process_each_lv Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1920&r2=1.1921 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/toollib.c.diff?cvsroot=lvm2&r1=1.220&r2=1.221 --- LVM2/WHATS_NEW 2011/02/18 14:47:28 1.1920 +++ LVM2/WHATS_NEW 2011/02/18 15:02:25 1.1921 @@ -1,5 +1,6 @@ Version 2.02.85 - =================================== + Add stack backtraces for error paths in process_each_lv(). Fixing some const cast gcc warnings in the code. Use char* arithmetic in _text_write(), _text_read() & send_message(). Fix compilation when devmapper is dissabled. --- LVM2/tools/toollib.c 2011/02/18 14:47:31 1.220 +++ LVM2/tools/toollib.c 2011/02/18 15:02:25 1.221 @@ -169,8 +169,10 @@ } if (ret > ret_max) ret_max = ret; - if (sigint_caught()) + if (sigint_caught()) { + stack; return ret_max; + } } if (lvargs_supplied && lvargs_matched != dm_list_size(arg_lvnames)) { @@ -253,8 +255,10 @@ while (*lv_name == '/') lv_name++; if (!(vgname = extract_vgname(cmd, vgname))) { - if (ret_max < ECMD_FAILED) + if (ret_max < ECMD_FAILED) { + stack; ret_max = ECMD_FAILED; + } continue; } } else if (!dev_dir_found && @@ -348,8 +352,10 @@ tags_arg, &failed_lvnames, handle, process_single_lv); if (ret != ECMD_PROCESSED || - dm_list_empty(&failed_lvnames)) + dm_list_empty(&failed_lvnames)) { + stack; break; + } /* Try again with failed LVs in this VG */ dm_list_init(&lvnames); @@ -357,6 +363,7 @@ free_cmd_vgs(&cmd_vgs); if (!cmd_vg_read(cmd, &cmd_vgs)) { + stack; ret = ECMD_FAILED; /* break */ break; } @@ -366,8 +373,10 @@ free_cmd_vgs(&cmd_vgs); /* FIXME: logic for breaking command is not consistent */ - if (sigint_caught()) + if (sigint_caught()) { + stack; return ECMD_FAILED; + } } return ret_max;
next reply other threads:[~2011-02-18 15:02 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-18 15:02 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2012-01-25 21:52 zkabelac 2011-11-18 19:19 zkabelac 2010-11-23 20:39 zkabelac 2010-05-21 14:15 zkabelac 2010-05-21 14:11 zkabelac 2010-05-21 12:19 zkabelac 2010-04-14 2:19 agk 2009-11-24 16:13 mbroz 2009-09-29 20:33 agk 2009-08-24 11:37 mbroz 2009-07-21 11:10 agk 2009-05-27 13:23 agk 2009-04-10 9:54 mbroz 2008-06-10 15:25 wysochanski 2008-02-06 16:09 agk 2008-01-03 19:03 agk 2007-09-11 20:12 meyering 2007-07-10 17:51 agk 2006-10-24 18:25 agk 2006-06-14 20:27 agk 2004-05-20 16:18 agk 2004-05-05 18:31 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110218150226.11654.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).