public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Date: Mon, 09 Jun 2008 16:22:00 -0000 [thread overview] Message-ID: <20080609162233.8203.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2008-06-09 16:22:33 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Fix segfault after _free_vginfo by remembering to remove vginfo from list. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.892&r2=1.893 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.56&r2=1.57 --- LVM2/WHATS_NEW 2008/06/08 14:18:44 1.892 +++ LVM2/WHATS_NEW 2008/06/09 16:22:32 1.893 @@ -1,5 +1,6 @@ Version 2.02.38 - ================================= + Fix segfault after _free_vginfo by remembering to remove vginfo from list. Tweak detection of invalid fid after changes to PVs in VG in _vg_read. Revert assuming precommitted metadata is live when activating (unnecessary). Drop cached metadata for disappearing VG in vgmerge. --- LVM2/lib/cache/lvmcache.c 2008/06/06 12:43:40 1.56 +++ LVM2/lib/cache/lvmcache.c 2008/06/09 16:22:33 1.57 @@ -631,11 +631,14 @@ static int _free_vginfo(struct lvmcache_vginfo *vginfo) { + struct lvmcache_vginfo *primary_vginfo, *vginfo2; int r = 1; _free_cached_vgmetadata(vginfo); - if (vginfo_from_vgname(vginfo->vgname, NULL) == vginfo) { + vginfo2 = primary_vginfo = vginfo_from_vgname(vginfo->vgname, NULL); + + if (vginfo == primary_vginfo) { dm_hash_remove(_vgname_hash, vginfo->vgname); if (vginfo->next && !dm_hash_insert(_vgname_hash, vginfo->vgname, vginfo->next)) { @@ -643,7 +646,12 @@ vginfo->vgname); r = 0; } - } + } else do + if (vginfo2->next == vginfo) { + vginfo2->next = vginfo->next; + break; + } + while ((vginfo2 = primary_vginfo->next)); if (vginfo->vgname) dm_free(vginfo->vgname);
next reply other threads:[~2008-06-09 16:22 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-06-09 16:22 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-29 21:34 zkabelac 2011-03-10 3:03 agk 2010-12-01 10:39 zkabelac 2010-03-31 17:20 mbroz 2009-10-22 17:33 agk 2009-02-17 18:56 agk 2008-11-27 18:13 agk 2008-06-11 11:02 agk 2008-05-08 18:28 agk 2006-06-14 20:11 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080609162233.8203.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).