public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Date: Wed, 01 Dec 2010 10:39:00 -0000 [thread overview] Message-ID: <20101201103929.8868.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-12-01 10:39:29 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Check result of vginfo_from_vgname Check for some potential internal error. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1820&r2=1.1821 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.97&r2=1.98 --- LVM2/WHATS_NEW 2010/12/01 10:33:55 1.1820 +++ LVM2/WHATS_NEW 2010/12/01 10:39:28 1.1821 @@ -1,5 +1,6 @@ Version 2.02.78 - ==================================== + Add test for existance of orphan vginfo in _lvmcache_update_vgname(). Do a full rescan if some device is missing in read_pvs_in_vg(). Avoid misleading warnings in vgextend --restoremissing in certain cases. Add error path stack traces for _process_mapper_dir(), _create_and_load_v4(). --- LVM2/lib/cache/lvmcache.c 2010/10/25 13:33:42 1.97 +++ LVM2/lib/cache/lvmcache.c 2010/12/01 10:39:29 1.98 @@ -1083,6 +1083,13 @@ _scanning_in_progress && _vginfo_is_invalid(primary_vginfo)) dm_list_iterate_items_safe(info2, info3, &primary_vginfo->infos) { orphan_vginfo = vginfo_from_vgname(primary_vginfo->fmt->orphan_vg_name, NULL); + if (!orphan_vginfo) { + log_error(INTERNAL_ERROR "Orphan vginfo %s lost from cache.", + primary_vginfo->fmt->orphan_vg_name); + dm_free(vginfo->vgname); + dm_free(vginfo); + return 0; + } _drop_vginfo(info2, primary_vginfo); _vginfo_attach_info(orphan_vginfo, info2); if (info2->mdas.n)
next reply other threads:[~2010-12-01 10:39 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-12-01 10:39 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-29 21:34 zkabelac 2011-03-10 3:03 agk 2010-03-31 17:20 mbroz 2009-10-22 17:33 agk 2009-02-17 18:56 agk 2008-11-27 18:13 agk 2008-06-11 11:02 agk 2008-06-09 16:22 agk 2008-05-08 18:28 agk 2006-06-14 20:11 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101201103929.8868.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).