public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: agk@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Date: Thu, 22 Oct 2009 17:33:00 -0000 [thread overview] Message-ID: <20091022173310.9275.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: agk@sourceware.org 2009-10-22 17:33:09 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Remember to clear 'global lock held during cache refresh' state after use. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1299&r2=1.1300 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.69&r2=1.70 --- LVM2/WHATS_NEW 2009/10/22 13:00:07 1.1299 +++ LVM2/WHATS_NEW 2009/10/22 17:33:09 1.1300 @@ -1,5 +1,6 @@ Version 2.02.54 - ===================================== + Remember to clear 'global lock held during cache refresh' state after use. Use udev flags support in LVM. Delay announcing mirror monitoring to syslog until initialisation succeeded. Handle metadata with unknown segment types more gracefully. --- LVM2/lib/cache/lvmcache.c 2009/09/15 13:49:11 1.69 +++ LVM2/lib/cache/lvmcache.c 2009/10/22 17:33:09 1.70 @@ -52,8 +52,15 @@ if (!(_lock_hash = dm_hash_create(128))) return 0; - if (_vg_global_lock_held) + /* + * Reinitialising the cache clears the internal record of + * which locks are held. The global lock can be held during + * this operation so its state must be restored afterwards. + */ + if (_vg_global_lock_held) { lvmcache_lock_vgname(VG_GLOBAL, 0); + _vg_global_lock_held = 0; + } return 1; }
next reply other threads:[~2009-10-22 17:33 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-22 17:33 agk [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-29 21:34 zkabelac 2011-03-10 3:03 agk 2010-12-01 10:39 zkabelac 2010-03-31 17:20 mbroz 2009-02-17 18:56 agk 2008-11-27 18:13 agk 2008-06-11 11:02 agk 2008-06-09 16:22 agk 2008-05-08 18:28 agk 2006-06-14 20:11 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091022173310.9275.qmail@sourceware.org \ --to=agk@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).