public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mbroz@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c Date: Wed, 31 Mar 2010 17:20:00 -0000 [thread overview] Message-ID: <20100331172045.32459.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mbroz@sourceware.org 2010-03-31 17:20:44 Modified files: . : WHATS_NEW lib/cache : lvmcache.c Log message: Remove vg_validate call when parsing cached metadata. vg_validate call is an adept to optimisation, it is very ineeficient and slow. Anyway, we should call it only before writing data to disk. The call in lvmcache was just temporary validation, we realy do not need to revalidate cached metadata every time. (Actually, I added that there just to prove that cache works properly and forgot to remove it.) Patch removes it from lvmcache completely, this can hit only internal bug in export function (and this bug must be detected in any vg_write call anyway before). Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1493&r2=1.1494 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.82&r2=1.83 --- LVM2/WHATS_NEW 2010/03/31 17:20:02 1.1493 +++ LVM2/WHATS_NEW 2010/03/31 17:20:44 1.1494 @@ -1,5 +1,6 @@ Version 2.02.63 - ================================ + Remove vg_validate call when parsing cached metadata. Use hash table of LVs to speed up parsing of text metadata with many LVs. Fix two messages, add a whitespace and parentheses When dmeventd is not forking because of -d flag, don't kill the parent process --- LVM2/lib/cache/lvmcache.c 2010/03/17 02:11:18 1.82 +++ LVM2/lib/cache/lvmcache.c 2010/03/31 17:20:44 1.83 @@ -610,8 +610,7 @@ vgid, NULL))) return_NULL; - if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid)) || - !vg_validate(vg)) { + if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid))) { _free_cached_vgmetadata(vginfo); vg_release(vg); return_NULL;
next reply other threads:[~2010-03-31 17:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-31 17:20 mbroz [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-03-29 21:34 zkabelac 2011-03-10 3:03 agk 2010-12-01 10:39 zkabelac 2009-10-22 17:33 agk 2009-02-17 18:56 agk 2008-11-27 18:13 agk 2008-06-11 11:02 agk 2008-06-09 16:22 agk 2008-05-08 18:28 agk 2006-06-14 20:11 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100331172045.32459.qmail@sourceware.org \ --to=mbroz@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).