public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: prajnoha@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvmcmdline.c Date: Fri, 19 Dec 2008 14:43:00 -0000 [thread overview] Message-ID: <20081219144303.19227.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: prajnoha@sourceware.org 2008-12-19 14:43:03 Modified files: . : WHATS_NEW tools : lvmcmdline.c Log message: Fix incorrect return value in help function. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1010&r2=1.1011 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.90&r2=1.91 --- LVM2/WHATS_NEW 2008/12/19 14:22:48 1.1010 +++ LVM2/WHATS_NEW 2008/12/19 14:43:02 1.1011 @@ -1,5 +1,6 @@ Version 2.02.44 - ==================================== + Fix incorrect return value in help function. Fix vgrename using UUID in case there are VGs with the same name. Fix segfault when invalid field given in reporting commands. Refactor init_lvm() for lvmcmdline and clvmd. --- LVM2/tools/lvmcmdline.c 2008/12/18 05:27:18 1.90 +++ LVM2/tools/lvmcmdline.c 2008/12/19 14:43:02 1.91 @@ -568,14 +568,17 @@ log_error("Run `%s --help' for more information.", name); } -static void _usage(const char *name) +static int _usage(const char *name) { struct command *com = _find_command(name); - if (!com) - return; + if (!com) { + log_print("%s: no such command.", name); + return 0; + } log_print("%s: %s\n\n%s", com->name, com->desc, com->usage); + return 1; } /* @@ -852,15 +855,18 @@ int help(struct cmd_context *cmd __attribute((unused)), int argc, char **argv) { + int ret = ECMD_PROCESSED; + if (!argc) _display_help(); else { int i; for (i = 0; i < argc; i++) - _usage(argv[i]); + if (!_usage(argv[i])) + ret = EINVALID_CMD_LINE; } - return 0; + return ret; } static int _override_settings(struct cmd_context *cmd)
next reply other threads:[~2008-12-19 14:43 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-12-19 14:43 prajnoha [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-09-16 12:10 zkabelac 2010-11-24 9:53 zkabelac 2010-09-30 11:44 zkabelac 2010-06-30 16:43 agk 2010-02-15 16:26 prajnoha 2008-01-09 15:55 mornfall 2007-09-21 18:06 meyering 2007-09-21 18:06 meyering 2006-11-14 15:28 agk 2005-08-31 19:32 agk 2005-03-03 22:09 agk 2004-12-22 21:47 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20081219144303.19227.qmail@sourceware.org \ --to=prajnoha@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).