public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvmcmdline.c Date: Fri, 16 Sep 2011 12:10:00 -0000 [thread overview] Message-ID: <20110916121003.24495.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2011-09-16 12:10:03 Modified files: . : WHATS_NEW tools : lvmcmdline.c Log message: Fix command line option decoding LVM has huge set of options now - it's approaching 60 short-arg less options and we get interesting case of misdetection for 'merge' option which has been put into the middle of options with 'short_arg' - thus certainly past 65. (ASCII 'A'). To avoid confusion of short_arg with long_opt number - add '128' to all such non-short-arg options. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.2114&r2=1.2115 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.147&r2=1.148 --- LVM2/WHATS_NEW 2011/09/16 12:01:48 1.2114 +++ LVM2/WHATS_NEW 2011/09/16 12:10:02 1.2115 @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Fix command line option decoding. Reset LV status when unlinking LV from VG. Fix overly strict extent-count divisibility requirements for striped mirrors. Fix rounding direction in lvresize when reducing volume size. --- LVM2/tools/lvmcmdline.c 2011/09/02 01:32:08 1.147 +++ LVM2/tools/lvmcmdline.c 2011/09/16 12:10:02 1.148 @@ -641,7 +641,7 @@ if (a->short_arg) (*o)->val = a->short_arg; else - (*o)->val = arg; + (*o)->val = arg + 128; (*o)++; } #endif @@ -662,7 +662,7 @@ * the_args. */ if ((a->short_arg && (opt == a->short_arg)) || - (!a->short_arg && (opt == arg))) + (!a->short_arg && (opt == (arg + 128)))) return arg; }
next reply other threads:[~2011-09-16 12:10 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-09-16 12:10 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2010-11-24 9:53 zkabelac 2010-09-30 11:44 zkabelac 2010-06-30 16:43 agk 2010-02-15 16:26 prajnoha 2008-12-19 14:43 prajnoha 2008-01-09 15:55 mornfall 2007-09-21 18:06 meyering 2007-09-21 18:06 meyering 2006-11-14 15:28 agk 2005-08-31 19:32 agk 2005-03-03 22:09 agk 2004-12-22 21:47 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110916121003.24495.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).