public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: zkabelac@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 ./WHATS_NEW tools/lvmcmdline.c Date: Thu, 30 Sep 2010 11:44:00 -0000 [thread overview] Message-ID: <20100930114458.23234.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: zkabelac@sourceware.org 2010-09-30 11:44:55 Modified files: . : WHATS_NEW tools : lvmcmdline.c Log message: Fix memory leak of config_tree Adding missing destroy_config_tree() for cft_override if it has been allocated. Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1740&r2=1.1741 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.127&r2=1.128 --- LVM2/WHATS_NEW 2010/09/30 11:40:14 1.1740 +++ LVM2/WHATS_NEW 2010/09/30 11:44:54 1.1741 @@ -1,5 +1,6 @@ Version 2.02.75 - ===================================== + Fix memory leak of config_tree in reinitialization code path. Swap pool destruction order in dmeventd_lvm2_exit() to fix leak report. Read whole /proc/self/maps file before working with maps entries. Speed up unquoting of quoted double quotes and backslashes. --- LVM2/tools/lvmcmdline.c 2010/07/09 15:34:48 1.127 +++ LVM2/tools/lvmcmdline.c 2010/09/30 11:44:54 1.128 @@ -1048,6 +1048,10 @@ if (arg_count(cmd, config_ARG) || !cmd->config_valid || config_files_changed(cmd)) { /* Reinitialise various settings inc. logging, filters */ if (!refresh_toolcontext(cmd)) { + if (cmd->cft_override) { + destroy_config_tree(cmd->cft_override); + cmd->cft_override = NULL; + } log_error("Updated config file invalid. Aborting."); return ECMD_FAILED; }
next reply other threads:[~2010-09-30 11:44 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-30 11:44 zkabelac [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-09-16 12:10 zkabelac 2010-11-24 9:53 zkabelac 2010-06-30 16:43 agk 2010-02-15 16:26 prajnoha 2008-12-19 14:43 prajnoha 2008-01-09 15:55 mornfall 2007-09-21 18:06 meyering 2007-09-21 18:06 meyering 2006-11-14 15:28 agk 2005-08-31 19:32 agk 2005-03-03 22:09 agk 2004-12-22 21:47 agk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100930114458.23234.qmail@sourceware.org \ --to=zkabelac@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).