public inbox for lvm2-cvs@sourceware.org
help / color / mirror / Atom feed
From: zkabelac@sourceware.org
To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org
Subject: LVM2 ./WHATS_NEW tools/lvmcmdline.c
Date: Wed, 24 Nov 2010 09:53:00 -0000 [thread overview]
Message-ID: <20101124095332.24720.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac@sourceware.org 2010-11-24 09:53:31
Modified files:
. : WHATS_NEW
tools : lvmcmdline.c
Log message:
Add missing destrustion of cmd_context
Lvm1 fallback code missed to destroy cmd_context in error path.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1808&r2=1.1809
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvmcmdline.c.diff?cvsroot=lvm2&r1=1.131&r2=1.132
--- LVM2/WHATS_NEW 2010/11/24 09:43:18 1.1808
+++ LVM2/WHATS_NEW 2010/11/24 09:53:31 1.1809
@@ -1,5 +1,6 @@
Version 2.02.78 -
====================================
+ Fix missing context desctruction in err path of lvm1 fallback in lvm2_main().
Fix memory leak in error path of parse_loop_device_name() from dmsetup.
Fix missing dlclose in _init_formats() error path from init_format call.
Fix missing fclose for _umount() in dmeventd snapshot plugin.
--- LVM2/tools/lvmcmdline.c 2010/11/17 10:19:30 1.131
+++ LVM2/tools/lvmcmdline.c 2010/11/24 09:53:31 1.132
@@ -1447,10 +1447,12 @@
if (!argc) {
log_error("Falling back to LVM1 tools, but no "
"command specified.");
- return ECMD_FAILED;
+ ret = ECMD_FAILED;
+ goto out;
}
_exec_lvm1_command(argv);
- return ECMD_FAILED;
+ ret = ECMD_FAILED;
+ goto out;
}
#ifdef READLINE_SUPPORT
if (!alias && argc == 1) {
next reply other threads:[~2010-11-24 9:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 9:53 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-16 12:10 zkabelac
2010-09-30 11:44 zkabelac
2010-06-30 16:43 agk
2010-02-15 16:26 prajnoha
2008-12-19 14:43 prajnoha
2008-01-09 15:55 mornfall
2007-09-21 18:06 meyering
2007-09-21 18:06 meyering
2006-11-14 15:28 agk
2005-08-31 19:32 agk
2005-03-03 22:09 agk
2004-12-22 21:47 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124095332.24720.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
--cc=lvm2-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).