public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/metadata-exported.h lib/meta ... Date: Thu, 09 Jul 2009 10:04:00 -0000 [thread overview] Message-ID: <20090709100453.4679.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-09 10:04:52 Modified files: lib/metadata : metadata-exported.h metadata.c tools : vgchange.c Log message: Rename vg_change_pesize to vg_set_extent_size and use vg_t. In liblvm, we will reserve the word 'change' to mean an API that both sets one or more values, and commits to disk. This will be consistent with the LVM commandline. The existing vg_change_pesize() function does not commit to disk, but just changes the extent_size and ensures all internal structures are updated. This logic should be contained in a function that sets the value. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.82&r2=1.83 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.236&r2=1.237 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.76&r2=1.77 --- LVM2/lib/metadata/metadata-exported.h 2009/07/09 10:03:37 1.82 +++ LVM2/lib/metadata/metadata-exported.h 2009/07/09 10:04:52 1.83 @@ -434,7 +434,7 @@ int vg_rename(struct cmd_context *cmd, struct volume_group *vg, const char *new_name); int vg_extend(struct volume_group *vg, int pv_count, char **pv_names); -int vg_change_pesize(struct volume_group *vg, uint32_t new_extent_size); +int vg_set_extent_size(vg_t *vg, uint32_t new_extent_size); int vg_split_mdas(struct cmd_context *cmd, struct volume_group *vg_from, struct volume_group *vg_to); --- LVM2/lib/metadata/metadata.c 2009/07/09 10:03:37 1.236 +++ LVM2/lib/metadata/metadata.c 2009/07/09 10:04:52 1.237 @@ -624,7 +624,7 @@ return 1; } -int vg_change_pesize(struct volume_group *vg, uint32_t new_size) +int vg_set_extent_size(vg_t *vg, uint32_t new_size) { uint32_t old_size = vg->extent_size; struct pv_list *pvl; --- LVM2/tools/vgchange.c 2009/07/09 10:03:37 1.76 +++ LVM2/tools/vgchange.c 2009/07/09 10:04:52 1.77 @@ -397,7 +397,7 @@ if (!archive(vg)) return ECMD_FAILED; - if (!vg_change_pesize(vg, extent_size)) { + if (!vg_set_extent_size(vg, extent_size)) { stack; return EINVALID_CMD_LINE; }
next reply other threads:[~2009-07-09 10:04 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-09 10:04 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-21 12:29 prajnoha 2010-10-12 16:41 mornfall 2010-06-30 20:03 agk 2010-06-30 18:03 wysochanski 2010-06-29 21:32 wysochanski 2010-06-28 20:40 wysochanski 2010-02-24 18:15 wysochanski 2010-02-24 18:15 wysochanski 2010-02-14 3:21 wysochanski 2010-02-14 3:21 wysochanski 2009-11-01 20:05 wysochanski 2009-11-01 19:51 wysochanski 2009-10-31 17:30 wysochanski 2009-10-05 20:03 wysochanski 2009-10-05 20:02 wysochanski 2009-10-01 1:04 agk 2009-09-14 15:45 wysochanski 2009-09-02 21:39 wysochanski 2009-09-02 21:39 wysochanski 2009-07-28 15:14 wysochanski 2009-07-28 13:17 wysochanski 2009-07-26 2:34 wysochanski 2009-07-26 1:53 wysochanski 2009-07-15 5:50 mornfall 2009-07-14 2:15 wysochanski 2009-07-10 20:07 wysochanski 2009-07-10 20:05 wysochanski 2009-07-09 10:09 wysochanski 2009-07-09 10:08 wysochanski 2009-07-09 10:07 wysochanski 2009-07-09 10:06 wysochanski 2009-07-09 10:03 wysochanski 2009-07-08 14:33 wysochanski 2009-07-01 17:01 wysochanski 2008-06-24 20:10 wysochanski 2008-01-16 19:54 wysochanski 2008-01-15 22:56 wysochanski 2007-12-22 2:13 agk 2007-11-15 22:11 agk 2007-07-23 21:03 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090709100453.4679.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).