public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/metadata-exported.h lib/meta ... Date: Sun, 14 Feb 2010 03:21:00 -0000 [thread overview] Message-ID: <20100214032108.8391.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2010-02-14 03:21:07 Modified files: lib/metadata : metadata-exported.h metadata.h liblvm : lvm_lv.c lvm_vg.c Log message: Fix off by 512 sizes for lvm2app. Internally we store sizes in sectors, but lvm2app exports sizes in bytes. We could get fancier and allow units configuration but this fix should do for now. Fixes rhbz561422. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.129&r2=1.130 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.h.diff?cvsroot=lvm2&r1=1.199&r2=1.200 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_lv.c.diff?cvsroot=lvm2&r1=1.16&r2=1.17 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_vg.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35 --- LVM2/lib/metadata/metadata-exported.h 2010/02/03 14:08:40 1.129 +++ LVM2/lib/metadata/metadata-exported.h 2010/02/14 03:21:06 1.130 @@ -25,6 +25,7 @@ #define MAX_STRIPES 128U #define SECTOR_SHIFT 9L +#define SECTOR_SIZE ( 1L << SECTOR_SHIFT ) #define STRIPE_SIZE_MIN ( (unsigned) lvm_getpagesize() >> SECTOR_SHIFT) /* PAGESIZE in sectors */ #define STRIPE_SIZE_MAX ( 512L * 1024L >> SECTOR_SHIFT) /* 512 KB in sectors */ #define STRIPE_SIZE_LIMIT ((UINT_MAX >> 2) + 1) --- LVM2/lib/metadata/metadata.h 2009/09/28 17:46:16 1.199 +++ LVM2/lib/metadata/metadata.h 2010/02/14 03:21:06 1.200 @@ -28,7 +28,7 @@ //#define MAX_STRIPES 128U //#define SECTOR_SHIFT 9L -#define SECTOR_SIZE ( 1L << SECTOR_SHIFT ) +//#define SECTOR_SIZE ( 1L << SECTOR_SHIFT ) //#define STRIPE_SIZE_MIN ( (unsigned) lvm_getpagesize() >> SECTOR_SHIFT) /* PAGESIZE in sectors */ //#define STRIPE_SIZE_MAX ( 512L * 1024L >> SECTOR_SHIFT) /* 512 KB in sectors */ //#define STRIPE_SIZE_LIMIT ((UINT_MAX >> 2) + 1) --- LVM2/liblvm/lvm_lv.c 2009/08/13 12:17:32 1.16 +++ LVM2/liblvm/lvm_lv.c 2010/02/14 03:21:06 1.17 @@ -26,7 +26,7 @@ /* FIXME: have lib/report/report.c _disp function call lv_size()? */ uint64_t lvm_lv_get_size(const lv_t lv) { - return lv_size(lv); + return SECTOR_SIZE*lv_size(lv); } char *lvm_lv_get_uuid(const lv_t lv) @@ -112,7 +112,7 @@ if (!vg_check_write_mode(vg)) return NULL; memset(&lp, 0, sizeof(lp)); - extents = extents_from_size(vg->cmd, size, vg->extent_size); + extents = extents_from_size(vg->cmd, size/SECTOR_SIZE, vg->extent_size); _lv_set_default_params(&lp, vg, name, extents); _lv_set_default_linear_params(vg->cmd, &lp); if (!lv_create_single(vg, &lp)) --- LVM2/liblvm/lvm_vg.c 2010/02/03 14:08:40 1.34 +++ LVM2/liblvm/lvm_vg.c 2010/02/14 03:21:06 1.35 @@ -86,7 +86,7 @@ if (!vg_check_write_mode(vg)) return -1; - if (!vg_set_extent_size(vg, new_size)) + if (!vg_set_extent_size(vg, new_size/SECTOR_SIZE)) return -1; return 0; } @@ -256,17 +256,17 @@ /* FIXME: invalid handle? return INTMAX? */ uint64_t lvm_vg_get_size(const vg_t vg) { - return vg_size(vg); + return SECTOR_SIZE*vg_size(vg); } uint64_t lvm_vg_get_free_size(const vg_t vg) { - return vg_free(vg); + return SECTOR_SIZE*vg_free(vg); } uint64_t lvm_vg_get_extent_size(const vg_t vg) { - return vg_extent_size(vg); + return SECTOR_SIZE*vg_extent_size(vg); } uint64_t lvm_vg_get_extent_count(const vg_t vg)
next reply other threads:[~2010-02-14 3:21 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-02-14 3:21 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-21 12:29 prajnoha 2010-10-12 16:41 mornfall 2010-06-30 20:03 agk 2010-06-30 18:03 wysochanski 2010-06-29 21:32 wysochanski 2010-06-28 20:40 wysochanski 2010-02-24 18:15 wysochanski 2010-02-24 18:15 wysochanski 2010-02-14 3:21 wysochanski 2009-11-01 20:05 wysochanski 2009-11-01 19:51 wysochanski 2009-10-31 17:30 wysochanski 2009-10-05 20:03 wysochanski 2009-10-05 20:02 wysochanski 2009-10-01 1:04 agk 2009-09-14 15:45 wysochanski 2009-09-02 21:39 wysochanski 2009-09-02 21:39 wysochanski 2009-07-28 15:14 wysochanski 2009-07-28 13:17 wysochanski 2009-07-26 2:34 wysochanski 2009-07-26 1:53 wysochanski 2009-07-15 5:50 mornfall 2009-07-14 2:15 wysochanski 2009-07-10 20:07 wysochanski 2009-07-10 20:05 wysochanski 2009-07-09 10:09 wysochanski 2009-07-09 10:08 wysochanski 2009-07-09 10:07 wysochanski 2009-07-09 10:06 wysochanski 2009-07-09 10:04 wysochanski 2009-07-09 10:03 wysochanski 2009-07-08 14:33 wysochanski 2009-07-01 17:01 wysochanski 2008-06-24 20:10 wysochanski 2008-01-16 19:54 wysochanski 2008-01-15 22:56 wysochanski 2007-12-22 2:13 agk 2007-11-15 22:11 agk 2007-07-23 21:03 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100214032108.8391.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).