public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: mornfall@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/metadata-exported.h lib/meta ... Date: Tue, 12 Oct 2010 16:41:00 -0000 [thread overview] Message-ID: <20101012164120.31556.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: mornfall@sourceware.org 2010-10-12 16:41:18 Modified files: lib/metadata : metadata-exported.h mirror.c tools : lvconvert.c Log message: Make lvconvert respect --yes/--force in the inactive log conversion prompt. Fixes BZs 642055, 621281. Patch by Taka. Signed-off-by: Takahiro Yasui <tyasui@redhat.com> Reviewed-by: Petr Rockai <prockai@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.168&r2=1.169 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.134&r2=1.135 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.146&r2=1.147 --- LVM2/lib/metadata/metadata-exported.h 2010/09/30 13:05:45 1.168 +++ LVM2/lib/metadata/metadata-exported.h 2010/10/12 16:41:17 1.169 @@ -652,7 +652,7 @@ struct logical_volume *detach_mirror_log(struct lv_segment *seg); int attach_mirror_log(struct lv_segment *seg, struct logical_volume *lv); int remove_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, - struct dm_list *removable_pvs); + struct dm_list *removable_pvs, int force); int add_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, uint32_t log_count, uint32_t region_size, struct dm_list *allocatable_pvs, alloc_policy_t alloc); --- LVM2/lib/metadata/mirror.c 2010/08/17 19:25:05 1.134 +++ LVM2/lib/metadata/mirror.c 2010/10/12 16:41:17 1.135 @@ -1573,7 +1573,8 @@ */ int remove_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, - struct dm_list *removable_pvs) + struct dm_list *removable_pvs, + int force) { float sync_percent; percent_range_t percent_range = PERCENT_0; @@ -1597,7 +1598,7 @@ log_error("Unable to convert the log of an inactive " "cluster mirror, %s", lv->name); return 0; - } else if (yes_no_prompt("Full resync required to convert " + } else if (force || yes_no_prompt("Full resync required to convert " "inactive mirror %s to core log. " "Proceed? [y/n]: ", lv->name) == 'y') sync_percent = 0; --- LVM2/tools/lvconvert.c 2010/08/17 16:25:35 1.146 +++ LVM2/tools/lvconvert.c 2010/10/12 16:41:18 1.147 @@ -747,7 +747,9 @@ /* Remove an existing log completely */ if (!log_count) { - if (!remove_mirror_log(cmd, original_lv, operable_pvs)) + if (!remove_mirror_log(cmd, original_lv, operable_pvs, + arg_count(cmd, yes_ARG) || + arg_count(cmd, force_ARG))) return_0; return 1; }
next reply other threads:[~2010-10-12 16:41 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-10-12 16:41 mornfall [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-21 12:29 prajnoha 2010-06-30 20:03 agk 2010-06-30 18:03 wysochanski 2010-06-29 21:32 wysochanski 2010-06-28 20:40 wysochanski 2010-02-24 18:15 wysochanski 2010-02-24 18:15 wysochanski 2010-02-14 3:21 wysochanski 2010-02-14 3:21 wysochanski 2009-11-01 20:05 wysochanski 2009-11-01 19:51 wysochanski 2009-10-31 17:30 wysochanski 2009-10-05 20:03 wysochanski 2009-10-05 20:02 wysochanski 2009-10-01 1:04 agk 2009-09-14 15:45 wysochanski 2009-09-02 21:39 wysochanski 2009-09-02 21:39 wysochanski 2009-07-28 15:14 wysochanski 2009-07-28 13:17 wysochanski 2009-07-26 2:34 wysochanski 2009-07-26 1:53 wysochanski 2009-07-15 5:50 mornfall 2009-07-14 2:15 wysochanski 2009-07-10 20:07 wysochanski 2009-07-10 20:05 wysochanski 2009-07-09 10:09 wysochanski 2009-07-09 10:08 wysochanski 2009-07-09 10:07 wysochanski 2009-07-09 10:06 wysochanski 2009-07-09 10:04 wysochanski 2009-07-09 10:03 wysochanski 2009-07-08 14:33 wysochanski 2009-07-01 17:01 wysochanski 2008-06-24 20:10 wysochanski 2008-01-16 19:54 wysochanski 2008-01-15 22:56 wysochanski 2007-12-22 2:13 agk 2007-11-15 22:11 agk 2007-07-23 21:03 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20101012164120.31556.qmail@sourceware.org \ --to=mornfall@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).