public inbox for lvm2-cvs@sourceware.org help / color / mirror / Atom feed
From: wysochanski@sourceware.org To: lvm-devel@redhat.com, lvm2-cvs@sourceware.org Subject: LVM2 lib/metadata/metadata-exported.h lib/meta ... Date: Fri, 10 Jul 2009 20:07:00 -0000 [thread overview] Message-ID: <20090710200703.25140.qmail@sourceware.org> (raw) CVSROOT: /cvs/lvm2 Module name: LVM2 Changes by: wysochanski@sourceware.org 2009-07-10 20:07:03 Modified files: lib/metadata : metadata-exported.h metadata.c tools : vgremove.c Log message: Remove force parameter from vg_remove_single, now the liblvm function. Move check for active LVs outside of library function. The vgremove liblvm function function will fail if there are active LVs. It will be the application's responsibility to check this condition and remove the LVs individually before calling vgremove. Note also that we've duplicated the EXPORTED_VG check in vgremove_single (tools) and vg_remove_single (library). Duplication seemed the only option here since we don't want to do the automatic removal of LVs (in the tools) if the vg is exported, and we still need to protect the library call from removal if the vg is exported. We still need to deal with the ORPHAN lock but vg_remove_single is now very close to our liblvm function. TODO: Refactor lvremove in a similar way. Signed-off-by: Dave Wysochanski <dwysocha@redhat.com> Patches: http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata-exported.h.diff?cvsroot=lvm2&r1=1.88&r2=1.89 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/metadata.c.diff?cvsroot=lvm2&r1=1.242&r2=1.243 http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgremove.c.diff?cvsroot=lvm2&r1=1.51&r2=1.52 --- LVM2/lib/metadata/metadata-exported.h 2009/07/10 20:05:29 1.88 +++ LVM2/lib/metadata/metadata-exported.h 2009/07/10 20:07:02 1.89 @@ -425,7 +425,7 @@ vg_t *vg_create(struct cmd_context *cmd, const char *vg_name); int vg_remove(struct volume_group *vg); -int vg_remove_single(vg_t *vg, force_t force); +int vg_remove_single(vg_t *vg); int vg_rename(struct cmd_context *cmd, struct volume_group *vg, const char *new_name); int vg_extend(struct volume_group *vg, int pv_count, char **pv_names); @@ -436,6 +436,10 @@ int vg_split_mdas(struct cmd_context *cmd, struct volume_group *vg_from, struct volume_group *vg_to); +/* FIXME: refactor / unexport when lvremove liblvm refactoring dones */ +int remove_lvs_in_vg(struct cmd_context *cmd, + struct volume_group *vg, + force_t force); /* * vg_release() must be called on every struct volume_group allocated * by vg_create() or vg_read_internal() to free it when no longer required. --- LVM2/lib/metadata/metadata.c 2009/07/10 20:05:29 1.242 +++ LVM2/lib/metadata/metadata.c 2009/07/10 20:07:02 1.243 @@ -343,9 +343,9 @@ return 1; } -static int remove_lvs_in_vg(struct cmd_context *cmd, - struct volume_group *vg, - force_t force) +int remove_lvs_in_vg(struct cmd_context *cmd, + struct volume_group *vg, + force_t force) { struct dm_list *lst; struct lv_list *lvl; @@ -359,7 +359,7 @@ return 1; } -int vg_remove_single(vg_t *vg, force_t force) +int vg_remove_single(vg_t *vg) { struct physical_volume *pv; struct pv_list *pvl; @@ -380,21 +380,6 @@ lv_count = vg_visible_lvs(vg); if (lv_count) { - if ((force == PROMPT) && - (yes_no_prompt("Do you really want to remove volume " - "group \"%s\" containing %u " - "logical volumes? [y/n]: ", - vg->name, lv_count) == 'n')) { - log_print("Volume group \"%s\" not removed", vg_name); - return 0; - } - if (!remove_lvs_in_vg(vg->cmd, vg, force)) - return 0; - } - - lv_count = vg_visible_lvs(vg); - - if (lv_count) { log_error("Volume group \"%s\" still contains %u " "logical volume(s)", vg->name, lv_count); return 0; --- LVM2/tools/vgremove.c 2009/07/10 20:05:29 1.51 +++ LVM2/tools/vgremove.c 2009/07/10 20:07:03 1.52 @@ -19,7 +19,29 @@ struct volume_group *vg, void *handle __attribute((unused))) { - if (!vg_remove_single(vg, arg_count(cmd, force_ARG))) + unsigned lv_count; + force_t force; + + if (!vg_check_status(vg, EXPORTED_VG)) + return ECMD_FAILED; + + lv_count = vg_visible_lvs(vg); + + force = arg_count(cmd, force_ARG); + if (lv_count) { + if ((force == PROMPT) && + (yes_no_prompt("Do you really want to remove volume " + "group \"%s\" containing %u " + "logical volumes? [y/n]: ", + vg_name, lv_count) == 'n')) { + log_print("Volume group \"%s\" not removed", vg_name); + return ECMD_FAILED; + } + if (!remove_lvs_in_vg(cmd, vg, force)) + return ECMD_FAILED; + } + + if (!vg_remove_single(vg)) return ECMD_FAILED; return ECMD_PROCESSED;
next reply other threads:[~2009-07-10 20:07 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-07-10 20:07 wysochanski [this message] -- strict thread matches above, loose matches on Subject: below -- 2011-02-21 12:29 prajnoha 2010-10-12 16:41 mornfall 2010-06-30 20:03 agk 2010-06-30 18:03 wysochanski 2010-06-29 21:32 wysochanski 2010-06-28 20:40 wysochanski 2010-02-24 18:15 wysochanski 2010-02-24 18:15 wysochanski 2010-02-14 3:21 wysochanski 2010-02-14 3:21 wysochanski 2009-11-01 20:05 wysochanski 2009-11-01 19:51 wysochanski 2009-10-31 17:30 wysochanski 2009-10-05 20:03 wysochanski 2009-10-05 20:02 wysochanski 2009-10-01 1:04 agk 2009-09-14 15:45 wysochanski 2009-09-02 21:39 wysochanski 2009-09-02 21:39 wysochanski 2009-07-28 15:14 wysochanski 2009-07-28 13:17 wysochanski 2009-07-26 2:34 wysochanski 2009-07-26 1:53 wysochanski 2009-07-15 5:50 mornfall 2009-07-14 2:15 wysochanski 2009-07-10 20:05 wysochanski 2009-07-09 10:09 wysochanski 2009-07-09 10:08 wysochanski 2009-07-09 10:07 wysochanski 2009-07-09 10:06 wysochanski 2009-07-09 10:04 wysochanski 2009-07-09 10:03 wysochanski 2009-07-08 14:33 wysochanski 2009-07-01 17:01 wysochanski 2008-06-24 20:10 wysochanski 2008-01-16 19:54 wysochanski 2008-01-15 22:56 wysochanski 2007-12-22 2:13 agk 2007-11-15 22:11 agk 2007-07-23 21:03 wysochanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090710200703.25140.qmail@sourceware.org \ --to=wysochanski@sourceware.org \ --cc=lvm-devel@redhat.com \ --cc=lvm2-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).