* Re: mauve ./ChangeLog gnu/testlet/java/lang/Charac ...
[not found] <20040408160537.21917.qmail@sources.redhat.com>
@ 2004-04-12 12:15 ` Mark Wielaard
2004-04-12 23:26 ` Stephen Crawley
2004-04-13 23:13 ` Stephen Crawley
0 siblings, 2 replies; 3+ messages in thread
From: Mark Wielaard @ 2004-04-12 12:15 UTC (permalink / raw)
To: crawley; +Cc: mauve-discuss
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
Hi Stephen,
On Thu, 2004-04-08 at 18:05, crawley@sources.redhat.com wrote:
> Fixed java.lang.Character.unicode test to match JDK 1.4 semantics
Nice cleanup!
One thing that seems to be missing though is the CharInfo.decimalDigit
field. Without such a field the code will not compile. But it seems we
don't use that field during the tests either. Should I add the following
or did you have something else in mind?
diff -u -r1.3 CharInfo.java
--- gnu/testlet/java/lang/Character/CharInfo.java 4 Feb 1999 18:46:19 -0000 1.3
+++ gnu/testlet/java/lang/Character/CharInfo.java 12 Apr 2004 12:12:44 -0000
@@ -29,6 +29,7 @@
{
public String name;
public String category;
+ public int decimalDigit;
public int digit;
public int numericValue;
public char uppercase;
With that it compiles again and java.lang.Character.unicode gives
0 of 3578944 tests failed for GNU Classpath :)
Cheers,
Mark
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: mauve ./ChangeLog gnu/testlet/java/lang/Charac ...
2004-04-12 12:15 ` mauve ./ChangeLog gnu/testlet/java/lang/Charac Mark Wielaard
@ 2004-04-12 23:26 ` Stephen Crawley
2004-04-13 23:13 ` Stephen Crawley
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Crawley @ 2004-04-12 23:26 UTC (permalink / raw)
To: Mark Wielaard; +Cc: crawley, mauve-discuss, crawley
Folks,
Mark Wielaard <mark@klomp.org> wrote:
> One thing that seems to be missing though is the CharInfo.decimalDigit
> field. Without such a field the code will not compile. But it seems we
> don't use that field during the tests either. Should I add the following
> or did you have something else in mind?
>
> diff -u -r1.3 CharInfo.java
> --- gnu/testlet/java/lang/Character/CharInfo.java 4 Feb 1999 18:46:19 -0000 1.3
> +++ gnu/testlet/java/lang/Character/CharInfo.java 12 Apr 2004 12:12:44 -0000
> @@ -29,6 +29,7 @@
> {
> public String name;
> public String category;
> + public int decimalDigit;
> public int digit;
> public int numericValue;
> public char uppercase;
OOPS!!
My apologies everyone. It looks like I forgot to check-in the change
to CharInfo!
Mark: your change is spot on.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: mauve ./ChangeLog gnu/testlet/java/lang/Charac ...
2004-04-12 12:15 ` mauve ./ChangeLog gnu/testlet/java/lang/Charac Mark Wielaard
2004-04-12 23:26 ` Stephen Crawley
@ 2004-04-13 23:13 ` Stephen Crawley
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Crawley @ 2004-04-13 23:13 UTC (permalink / raw)
To: Mark Wielaard; +Cc: crawley, mauve-discuss, crawley
Hi Mark,
I've now checked in the missing update for CharInfo.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-04-13 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20040408160537.21917.qmail@sources.redhat.com>
2004-04-12 12:15 ` mauve ./ChangeLog gnu/testlet/java/lang/Charac Mark Wielaard
2004-04-12 23:26 ` Stephen Crawley
2004-04-13 23:13 ` Stephen Crawley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).