* Unicode test noise
@ 2005-01-31 11:35 Jeroen Frijters
2005-01-31 11:41 ` Michael Koch
0 siblings, 1 reply; 4+ messages in thread
From: Jeroen Frijters @ 2005-01-31 11:35 UTC (permalink / raw)
To: mauve-discuss
Hi,
Does anyone have any objections against this patch to eliminate the
noise that the unicode test generates?
Regards,
Jeroen
Index: gnu/testlet/java/lang/Character/UnicodeBase.java
===================================================================
RCS file:
/cvs/mauve/mauve/gnu/testlet/java/lang/Character/UnicodeBase.java,v
retrieving revision 1.1
diff -u -r1.1 UnicodeBase.java
--- gnu/testlet/java/lang/Character/UnicodeBase.java 8 Apr 2004
16:05:36 -0000 1.1
+++ gnu/testlet/java/lang/Character/UnicodeBase.java 31 Jan 2005
11:34:16 -0000
@@ -276,7 +276,6 @@
protected void checkPassed()
{
- harness.check(true);
}
public boolean range(int mid, int low, int high)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unicode test noise
2005-01-31 11:35 Unicode test noise Jeroen Frijters
@ 2005-01-31 11:41 ` Michael Koch
0 siblings, 0 replies; 4+ messages in thread
From: Michael Koch @ 2005-01-31 11:41 UTC (permalink / raw)
To: mauve-discuss; +Cc: Jeroen Frijters
Am Montag, 31. Januar 2005 12:34 schrieb Jeroen Frijters:
> Hi,
>
> Does anyone have any objections against this patch to eliminate the
> noise that the unicode test generates?
Why don't you just skip the tests ? You change would make the tests
don't show up in summaries when they succeed.
Michael
--
Homepage: http://www.worldforge.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unicode test noise
2005-01-31 12:14 Jeroen Frijters
@ 2005-01-31 12:32 ` Thomas Zander
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zander @ 2005-01-31 12:32 UTC (permalink / raw)
To: Jeroen Frijters; +Cc: mauve-discuss
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
But it really is a lot of tests; there is nothing wrong with that.
The real fix is in a better runner. Perhaps I should publish the runner I
have been working on, it solves this problem already. (except that you
get one page which is really big :)
I think any of those changes are not a good idea.
On Mon, Jan 31, 2005 at 01:13:58PM +0100, Jeroen Frijters wrote:
> Michael Koch wrote:
> > Am Montag, 31. Januar 2005 12:34 schrieb Jeroen Frijters:
> > > Hi,
> > >
> > > Does anyone have any objections against this patch to eliminate the
> > > noise that the unicode test generates?
> >
> > Why don't you just skip the tests ? You change would make the tests
> > don't show up in summaries when they succeed.
>
> I don't want to skip the tests, it's just that I don't think it is
> meaningful to have that single test count as 3.5 million tests, and in
> addition it makes the -verbose option incredibly slow.
>
> How about this patch?
>
> Regards,
> Jeroen
--
Thomas Zander
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Unicode test noise
@ 2005-01-31 12:14 Jeroen Frijters
2005-01-31 12:32 ` Thomas Zander
0 siblings, 1 reply; 4+ messages in thread
From: Jeroen Frijters @ 2005-01-31 12:14 UTC (permalink / raw)
To: Michael Koch, mauve-discuss
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
Michael Koch wrote:
> Am Montag, 31. Januar 2005 12:34 schrieb Jeroen Frijters:
> > Hi,
> >
> > Does anyone have any objections against this patch to eliminate the
> > noise that the unicode test generates?
>
> Why don't you just skip the tests ? You change would make the tests
> don't show up in summaries when they succeed.
I don't want to skip the tests, it's just that I don't think it is
meaningful to have that single test count as 3.5 million tests, and in
addition it makes the -verbose option incredibly slow.
How about this patch?
Regards,
Jeroen
[-- Attachment #2: unicode.txt --]
[-- Type: text/plain, Size: 1235 bytes --]
Index: gnu/testlet/java/lang/Character/UnicodeBase.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/lang/Character/UnicodeBase.java,v
retrieving revision 1.1
diff -u -r1.1 UnicodeBase.java
--- gnu/testlet/java/lang/Character/UnicodeBase.java 8 Apr 2004 16:05:36 -0000 1.1
+++ gnu/testlet/java/lang/Character/UnicodeBase.java 31 Jan 2005 12:13:11 -0000
@@ -43,7 +43,7 @@
public int failures;
public int tests;
TestHarness harness;
-
+ private boolean failed;
public UnicodeBase()
{
@@ -266,17 +266,18 @@
protected void reportError( String what)
{
- harness.check(false, what);
+ failed = true;
+ harness.debug(what);
}
protected void reportError( int ch, String what)
{
- harness.check(false, stringChar(ch) +" incorrectly reported as " + what);
+ failed = true;
+ harness.debug(stringChar(ch) +" incorrectly reported as " + what);
}
protected void checkPassed()
{
- harness.check(true);
}
public boolean range(int mid, int low, int high)
@@ -675,6 +676,8 @@
else checkPassed();
}
}
+
+ harness.check(!failed);
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-01-31 12:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-31 11:35 Unicode test noise Jeroen Frijters
2005-01-31 11:41 ` Michael Koch
2005-01-31 12:14 Jeroen Frijters
2005-01-31 12:32 ` Thomas Zander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).