* [Patch] Use .syntax unified for arm assembly language routines
@ 2017-03-29 23:24 Moore, Catherine
2017-03-30 14:09 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Moore, Catherine @ 2017-03-29 23:24 UTC (permalink / raw)
To: newlib; +Cc: Moore, Catherine
The LLVM integrated assembler doesn't support .syntax divided. I'd like to switch to .syntax unified for these two files.
For testing, I used GAS to build the files with .syntax divided and .syntax unified and compared the object files for differences.
They compared the same.
OK to commit?
Thanks,
Catherine
diff --git a/newlib/libc/machine/arm/aeabi_memmove-arm.S b/newlib/libc/machine/arm/aeabi_memmove-arm.S
index e6e9639..541444d 100644
--- a/newlib/libc/machine/arm/aeabi_memmove-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memmove-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memmove
.type __aeabi_memmove, %function
ASM_ALIAS __aeabi_memmove4 __aeabi_memmove
diff --git a/newlib/libc/machine/arm/aeabi_memset-arm.S b/newlib/libc/machine/arm/aeabi_memset-arm.S
index 0f91e3a..1c7bec5 100644
--- a/newlib/libc/machine/arm/aeabi_memset-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memset-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memset
.type __aeabi_memset, %function
ASM_ALIAS __aeabi_memset4 __aeabi_memset
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] Use .syntax unified for arm assembly language routines
2017-03-29 23:24 [Patch] Use .syntax unified for arm assembly language routines Moore, Catherine
@ 2017-03-30 14:09 ` Corinna Vinschen
2017-03-30 14:42 ` Moore, Catherine
0 siblings, 1 reply; 4+ messages in thread
From: Corinna Vinschen @ 2017-03-30 14:09 UTC (permalink / raw)
To: Moore, Catherine; +Cc: newlib
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
Hi Catherine,
On Mar 29 23:24, Moore, Catherine wrote:
> The LLVM integrated assembler doesn't support .syntax divided. I'd like to switch to .syntax unified for these two files.
>
> For testing, I used GAS to build the files with .syntax divided and .syntax unified and compared the object files for differences.
> They compared the same.
>
> OK to commit?
In theory yes, but your patch doesn't apply because it contains spaces
where the original file has TABs. Can you please regenerate the patch
with `git format-patch' and attach it to a mail? That works better most
of the time.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Patch] Use .syntax unified for arm assembly language routines
2017-03-30 14:09 ` Corinna Vinschen
@ 2017-03-30 14:42 ` Moore, Catherine
2017-03-30 15:19 ` Corinna Vinschen
0 siblings, 1 reply; 4+ messages in thread
From: Moore, Catherine @ 2017-03-30 14:42 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
> -----Original Message-----
> From: Corinna Vinschen [mailto:vinschen@redhat.com]
> Sent: Thursday, March 30, 2017 10:09 AM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: newlib@sourceware.org
> Subject: Re: [Patch] Use .syntax unified for arm assembly language
> routines
>
> Hi Catherine,
>
> On Mar 29 23:24, Moore, Catherine wrote:
> > The LLVM integrated assembler doesn't support .syntax divided. I'd
> like to switch to .syntax unified for these two files.
> >
> > For testing, I used GAS to build the files with .syntax divided and
> .syntax unified and compared the object files for differences.
> > They compared the same.
> >
> > OK to commit?
>
> In theory yes, but your patch doesn't apply because it contains spaces
> where the original file has TABs. Can you please regenerate the patch
> with `git format-patch' and attach it to a mail? That works better most
> of the time.
>
>
Sorry about that. Reformatted patch attached.
Thanks,
Catherine
[-- Attachment #2: 0001-Use-.syntax-unified-instead-of-.syntax-divided.patch --]
[-- Type: application/octet-stream, Size: 1236 bytes --]
From d8f7d4657b137a8a485ecdbf5f52bc4b61f3ef31 Mon Sep 17 00:00:00 2001
From: Catherine Moore <clm@codesourcery.com>
Date: Thu, 30 Mar 2017 07:26:23 -0700
Subject: [PATCH] Use .syntax unified instead of .syntax divided.
---
newlib/libc/machine/arm/aeabi_memmove-arm.S | 2 +-
newlib/libc/machine/arm/aeabi_memset-arm.S | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/libc/machine/arm/aeabi_memmove-arm.S b/newlib/libc/machine/arm/aeabi_memmove-arm.S
index e6e9639..541444d 100644
--- a/newlib/libc/machine/arm/aeabi_memmove-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memmove-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memmove
.type __aeabi_memmove, %function
ASM_ALIAS __aeabi_memmove4 __aeabi_memmove
diff --git a/newlib/libc/machine/arm/aeabi_memset-arm.S b/newlib/libc/machine/arm/aeabi_memset-arm.S
index 0f91e3a..1c7bec5 100644
--- a/newlib/libc/machine/arm/aeabi_memset-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memset-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memset
.type __aeabi_memset, %function
ASM_ALIAS __aeabi_memset4 __aeabi_memset
--
2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] Use .syntax unified for arm assembly language routines
2017-03-30 14:42 ` Moore, Catherine
@ 2017-03-30 15:19 ` Corinna Vinschen
0 siblings, 0 replies; 4+ messages in thread
From: Corinna Vinschen @ 2017-03-30 15:19 UTC (permalink / raw)
To: Moore, Catherine; +Cc: newlib
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
On Mar 30 14:42, Moore, Catherine wrote:
>
>
> > -----Original Message-----
> > From: Corinna Vinschen [mailto:vinschen@redhat.com]
> > Sent: Thursday, March 30, 2017 10:09 AM
> > To: Moore, Catherine <Catherine_Moore@mentor.com>
> > Cc: newlib@sourceware.org
> > Subject: Re: [Patch] Use .syntax unified for arm assembly language
> > routines
> >
> > Hi Catherine,
> >
> > On Mar 29 23:24, Moore, Catherine wrote:
> > > The LLVM integrated assembler doesn't support .syntax divided. I'd
> > like to switch to .syntax unified for these two files.
> > >
> > > For testing, I used GAS to build the files with .syntax divided and
> > .syntax unified and compared the object files for differences.
> > > They compared the same.
> > >
> > > OK to commit?
> >
> > In theory yes, but your patch doesn't apply because it contains spaces
> > where the original file has TABs. Can you please regenerate the patch
> > with `git format-patch' and attach it to a mail? That works better most
> > of the time.
> >
> >
>
> Sorry about that. Reformatted patch attached.
> Thanks,
> Catherine
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-30 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-29 23:24 [Patch] Use .syntax unified for arm assembly language routines Moore, Catherine
2017-03-30 14:09 ` Corinna Vinschen
2017-03-30 14:42 ` Moore, Catherine
2017-03-30 15:19 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).