From: Corinna Vinschen <vinschen@redhat.com>
To: Torbjorn SVENSSON <torbjorn.svensson@st.com>,
Jeff Johnston <jjohnstn@redhat.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h
Date: Thu, 15 Oct 2020 19:11:36 +0200 [thread overview]
Message-ID: <20201015171136.GA582570@calimero.vinschen.de> (raw)
In-Reply-To: <AM6PR10MB2197B2994CC0754BBA0814AA81020@AM6PR10MB2197.EURPRD10.PROD.OUTLOOK.COM>
On Oct 15 16:47, Torbjorn SVENSSON via Newlib wrote:
> Hello Corinna,
>
> Thanks for the feedback and I hope that you had a nice vacation!
>
> I haven't run tests with your patch applied, but just reading it should be fine.
> I see no reason why "sys/_tz_structs.h" would be included from
> "bits/stdc++.h", and it is this particular include chain that is
> causing the problems in the libstdc ++ test suite, so if it works for
> Cygwin, I'd say go for it!
Thanks for reviewing. I'll push the patch in a minute. I still
think we should rename the struct members as well, though. There's
no good reason that we have a user of these structures outside
newlib/Cygwin. But still, *iff* this file is included for whatever
dubious purpose, it might result in problems.
We have two ways to fix this:
- Either guard the definitions additionally with a preprocessor
expression like this:
#if defined (__INSIDE_CYGWIN__) || defined (_COMPILING_NEWLIB)
[...]
#endif
- or fix the names of the struct members and the newlib/Cygwin code
using them.
Thoughts? Jeff?
Corinna
prev parent reply other threads:[~2020-10-15 17:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:17 [PATCH 0/3] libc: Comply with the libstdc++ test case names.cc Torbjörn SVENSSON
2020-10-01 14:17 ` [PATCH 1/3] libc/include/inttypes.h: Remove parameter name Torbjörn SVENSSON
2020-10-01 23:22 ` Jeff Johnston
2020-10-02 6:52 ` Torbjorn SVENSSON
2020-10-02 6:53 ` nrupp
2020-10-02 21:01 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 2/3] libc/include/wchar.h: " Torbjörn SVENSSON
2020-10-01 23:24 ` Jeff Johnston
2020-10-02 6:53 ` Torbjorn SVENSSON
2020-10-02 21:02 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 3/3] libc: Replace one letter member names in __tzrule_struct Torbjörn SVENSSON
2020-10-01 23:21 ` Jeff Johnston
2020-10-02 7:36 ` Torbjorn SVENSSON
2020-10-02 21:04 ` Jeff Johnston
2020-10-05 12:50 ` [PATCH v2] libc/time: Move internal newlib tz-structs to local.h Torbjörn SVENSSON
2020-10-15 6:52 ` Torbjorn SVENSSON
2020-10-15 10:21 ` Corinna Vinschen
2020-10-15 16:47 ` Torbjorn SVENSSON
2020-10-15 17:09 ` Jeff Johnston
2020-10-15 17:15 ` Corinna Vinschen
2020-10-15 17:11 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015171136.GA582570@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
--cc=torbjorn.svensson@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).