From: Jeff Johnston <jjohnstn@redhat.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@st.com>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH 1/3] libc/include/inttypes.h: Remove parameter name
Date: Thu, 1 Oct 2020 19:22:44 -0400 [thread overview]
Message-ID: <CAOox84sRsEVB4xa2zjyDfJ34Ljsf_X6=oouYzCXp-Qin+YWwBA@mail.gmail.com> (raw)
In-Reply-To: <20201001141753.6657-2-torbjorn.svensson@st.com>
Looks fine. Could you please resend the patch as an attachment?
Thanks,
-- Jeff J.
On Thu, Oct 1, 2020 at 10:19 AM Torbjörn SVENSSON via Newlib <
newlib@sourceware.org> wrote:
> As discussed in GCC bug 97088
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
> prototypes of library functions should use reserved names, or no name
> at all.
>
> This patch removes the 'j' parameter name from
> extern intmax_t imaxabs(intmax_t);
>
> to avoid possible clashes with user code in case someone uses
> before including Newlib's inttypes.h (or uses some other conflicting
> definition)
>
> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
> ---
> newlib/libc/include/inttypes.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/include/inttypes.h
> b/newlib/libc/include/inttypes.h
> index 073215476..570ed0481 100644
> --- a/newlib/libc/include/inttypes.h
> +++ b/newlib/libc/include/inttypes.h
> @@ -320,7 +320,7 @@ struct _reent;
> extern "C" {
> #endif
>
> -extern intmax_t imaxabs(intmax_t j);
> +extern intmax_t imaxabs(intmax_t);
> extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);
> extern intmax_t strtoimax(const char *__restrict, char **__restrict,
> int);
> extern intmax_t _strtoimax_r(struct _reent *, const char *__restrict,
> char **__restrict, int);
> --
> 2.18.0
>
>
next prev parent reply other threads:[~2020-10-01 23:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:17 [PATCH 0/3] libc: Comply with the libstdc++ test case names.cc Torbjörn SVENSSON
2020-10-01 14:17 ` [PATCH 1/3] libc/include/inttypes.h: Remove parameter name Torbjörn SVENSSON
2020-10-01 23:22 ` Jeff Johnston [this message]
2020-10-02 6:52 ` Torbjorn SVENSSON
2020-10-02 6:53 ` nrupp
2020-10-02 21:01 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 2/3] libc/include/wchar.h: " Torbjörn SVENSSON
2020-10-01 23:24 ` Jeff Johnston
2020-10-02 6:53 ` Torbjorn SVENSSON
2020-10-02 21:02 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 3/3] libc: Replace one letter member names in __tzrule_struct Torbjörn SVENSSON
2020-10-01 23:21 ` Jeff Johnston
2020-10-02 7:36 ` Torbjorn SVENSSON
2020-10-02 21:04 ` Jeff Johnston
2020-10-05 12:50 ` [PATCH v2] libc/time: Move internal newlib tz-structs to local.h Torbjörn SVENSSON
2020-10-15 6:52 ` Torbjorn SVENSSON
2020-10-15 10:21 ` Corinna Vinschen
2020-10-15 16:47 ` Torbjorn SVENSSON
2020-10-15 17:09 ` Jeff Johnston
2020-10-15 17:15 ` Corinna Vinschen
2020-10-15 17:11 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84sRsEVB4xa2zjyDfJ34Ljsf_X6=oouYzCXp-Qin+YWwBA@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
--cc=torbjorn.svensson@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).