From: "Torbjörn SVENSSON" <torbjorn.svensson@st.com>
To: <newlib@sourceware.org>
Subject: [PATCH 0/3] libc: Comply with the libstdc++ test case names.cc
Date: Thu, 1 Oct 2020 16:17:50 +0200 [thread overview]
Message-ID: <20201001141753.6657-1-torbjorn.svensson@st.com> (raw)
As discussed in GCC bug 97088
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
prototypes of library functions should use reserved names, or no name
at all.
It's somewhat unclear how to handle members in structs, but as the
__tzrule_struct is an internal newlib struct, I don't see any point
in not trying to comply here too.
Without the patches, you will get errors like:
In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/ctime:42,
from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:49,
from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199:
/work/install-native/arm-none-eabi/include/time.h:110: error: expected unqualified-id before ';' token
/work/install-native/arm-none-eabi/include/time.h:110: error: expected ')' before ';' token
/work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:55: note: to match this '('
In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/cwchar:44,
from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:50,
from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199:
/work/install-native/arm-none-eabi/include/wchar.h:251: error: expected ')' before ';' token
/work/install-native/arm-none-eabi/include/wchar.h:252: error: expected ')' before ';' token
In file included from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/cinttypes:46,
from /work/build-native/gcc-final/arm-none-eabi/thumb/v6-m/nofp/libstdc++-v3/include/arm-none-eabi/bits/stdc++.h:56,
from /work/src/gcc/libstdc++-v3/testsuite/17_intro/names.cc:199:
/work/install-native/arm-none-eabi/include/inttypes.h:323: error: expected ')' before ';' token
I'd need someone to help me push the patches since I have no commit
access.
Torbjörn SVENSSON (3):
libc/include/inttypes.h: Remove parameter name
libc/include/wchar.h: Remove parameter name
libc: Replace one letter member names in __tzrule_struct
newlib/libc/include/inttypes.h | 2 +-
newlib/libc/include/time.h | 8 ++++----
newlib/libc/include/wchar.h | 4 ++--
newlib/libc/time/tzcalc_limits.c | 14 +++++++-------
newlib/libc/time/tzset_r.c | 22 +++++++++++-----------
5 files changed, 25 insertions(+), 25 deletions(-)
--
2.18.0
next reply other threads:[~2020-10-01 14:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:17 Torbjörn SVENSSON [this message]
2020-10-01 14:17 ` [PATCH 1/3] libc/include/inttypes.h: Remove parameter name Torbjörn SVENSSON
2020-10-01 23:22 ` Jeff Johnston
2020-10-02 6:52 ` Torbjorn SVENSSON
2020-10-02 6:53 ` nrupp
2020-10-02 21:01 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 2/3] libc/include/wchar.h: " Torbjörn SVENSSON
2020-10-01 23:24 ` Jeff Johnston
2020-10-02 6:53 ` Torbjorn SVENSSON
2020-10-02 21:02 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 3/3] libc: Replace one letter member names in __tzrule_struct Torbjörn SVENSSON
2020-10-01 23:21 ` Jeff Johnston
2020-10-02 7:36 ` Torbjorn SVENSSON
2020-10-02 21:04 ` Jeff Johnston
2020-10-05 12:50 ` [PATCH v2] libc/time: Move internal newlib tz-structs to local.h Torbjörn SVENSSON
2020-10-15 6:52 ` Torbjorn SVENSSON
2020-10-15 10:21 ` Corinna Vinschen
2020-10-15 16:47 ` Torbjorn SVENSSON
2020-10-15 17:09 ` Jeff Johnston
2020-10-15 17:15 ` Corinna Vinschen
2020-10-15 17:11 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001141753.6657-1-torbjorn.svensson@st.com \
--to=torbjorn.svensson@st.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).