From: Corinna Vinschen <vinschen@redhat.com>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to local.h
Date: Thu, 15 Oct 2020 19:15:31 +0200 [thread overview]
Message-ID: <20201015171531.GB582570@calimero.vinschen.de> (raw)
In-Reply-To: <CAOox84sDepHtGxO+s=XwoGi8pXcj6odzMaCyinDp6cfuUWP53Q@mail.gmail.com>
On Oct 15 13:09, Jeff Johnston via Newlib wrote:
> I also like this solution, but again as I mentioned earlier, it technically
> requires a major release bump due to the removal of API from time.h and
> would be best
> to wait until we have something else warranting a major release bump.
>
> That said, what do you think Corinna?
Oops, time warp! Sorry, but I already pushed this.
From my POV, these *are* internal structs and functions, so,
technically, they are *not* official API and consequentially
nobody has the right to expect them in an official header.
For me the only problem is that the members are not underscored
and may produce problems.
Corinna
>
> -- Jeff J.
>
> On Thu, Oct 15, 2020 at 12:47 PM Torbjorn SVENSSON via Newlib <
> newlib@sourceware.org> wrote:
>
> > Hello Corinna,
> >
> > Thanks for the feedback and I hope that you had a nice vacation!
> >
> > I haven't run tests with your patch applied, but just reading it should be
> > fine.
> > I see no reason why "sys/_tz_structs.h" would be included from
> > "bits/stdc++.h", and it is this particular include chain that is causing
> > the problems in the libstdc ++ test suite, so if it works for Cygwin, I'd
> > say go for it!
> >
> > Kind regards,
> > Torbjörn
> >
> > -----Original Message-----
> > From: Corinna Vinschen <vinschen@redhat.com>
> > Sent: den 15 oktober 2020 12:22
> > To: Torbjorn SVENSSON <torbjorn.svensson@st.com>
> > Cc: newlib@sourceware.org
> > Subject: Re: [PATCH v2] libc/time: Move internal newlib tz-structs to
> > local.h
> >
> > On Oct 15 06:52, Torbjorn SVENSSON via Newlib wrote:
> > > Ping!
> >
> > Due to vacation I only just checked now. The patch breaks the Cygwin
> > build. Especially __tzinfo_type has to be exposed from a public header
> > in newlib.
> >
> > So what about the attached patch instead?
> >
> >
> > Corinna
> >
next prev parent reply other threads:[~2020-10-15 17:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:17 [PATCH 0/3] libc: Comply with the libstdc++ test case names.cc Torbjörn SVENSSON
2020-10-01 14:17 ` [PATCH 1/3] libc/include/inttypes.h: Remove parameter name Torbjörn SVENSSON
2020-10-01 23:22 ` Jeff Johnston
2020-10-02 6:52 ` Torbjorn SVENSSON
2020-10-02 6:53 ` nrupp
2020-10-02 21:01 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 2/3] libc/include/wchar.h: " Torbjörn SVENSSON
2020-10-01 23:24 ` Jeff Johnston
2020-10-02 6:53 ` Torbjorn SVENSSON
2020-10-02 21:02 ` Jeff Johnston
2020-10-01 14:17 ` [PATCH 3/3] libc: Replace one letter member names in __tzrule_struct Torbjörn SVENSSON
2020-10-01 23:21 ` Jeff Johnston
2020-10-02 7:36 ` Torbjorn SVENSSON
2020-10-02 21:04 ` Jeff Johnston
2020-10-05 12:50 ` [PATCH v2] libc/time: Move internal newlib tz-structs to local.h Torbjörn SVENSSON
2020-10-15 6:52 ` Torbjorn SVENSSON
2020-10-15 10:21 ` Corinna Vinschen
2020-10-15 16:47 ` Torbjorn SVENSSON
2020-10-15 17:09 ` Jeff Johnston
2020-10-15 17:15 ` Corinna Vinschen [this message]
2020-10-15 17:11 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015171531.GB582570@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).