public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1/5] libgloss: msp430: delete outdated/wrong code
@ 2023-12-27  3:24 Mike Frysinger
  2023-12-27  3:24 ` [PATCH 2/5] libgloss: msp430: delete stub crt_init.o Mike Frysinger
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Mike Frysinger @ 2023-12-27  3:24 UTC (permalink / raw)
  To: newlib

The #if 0 & comment imply this code doesn't exist and is never used,
except there's another #if Lrun_fini_array section below which *does*
define this function, which makes this code comment confusing.  This
seems to be a hold over of the cleanup of the minrt code in the old
commit 884b05b54e4595433c85f8ca9820e88b4c723e38 ("MSP430: Remove
.init/.fini sections").
---
 libgloss/msp430/crt0.S | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/libgloss/msp430/crt0.S b/libgloss/msp430/crt0.S
index 88876cd48300..c0b258f508d2 100644
--- a/libgloss/msp430/crt0.S
+++ b/libgloss/msp430/crt0.S
@@ -195,20 +195,6 @@ START_CRT_FUNC 0600 run_init_array
 END_CRT_FUNC	run_init_array
 #endif /* Lrun_init_array */
 
-;; FIXME: There are currently no program termination routines executed for
-;; msp430.
-#if 0
-#if Lrun_fini_array
-;; Ensure global C++ destructors in .fini_array are called on exit
-;; by registering __crt0_run_fini_array with atexit.
-START_CRT_FUNC 0700 register_fini_array
-
-	mov_	#__crt0_run_fini_array, R12
-	call_	#atexit
-
-END_CRT_FUNC	register_fini_array
-#endif /* Lrun_fini_array */
-#endif /* 0 */
 
 #if Lmain
 ;; This function is always included and calls main().
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-12-27  3:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-27  3:24 [PATCH 1/5] libgloss: msp430: delete outdated/wrong code Mike Frysinger
2023-12-27  3:24 ` [PATCH 2/5] libgloss: msp430: delete stub crt_init.o Mike Frysinger
2023-12-27  3:24 ` [PATCH 3/5] libgloss: msp430: split up crt0.S source Mike Frysinger
2023-12-27  3:24 ` [PATCH 4/5] libgloss: msp430: delete custom .S.o rule Mike Frysinger
2023-12-27  3:24 ` [PATCH 5/5] libgloss: merge msp430 into top-level Makefile Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).