From: Neal Frager <neal.frager@amd.com>
To: <newlib@sourceware.org>
Cc: <cjwfirmware@vxmdesign.com>, <jjohnstn@redhat.com>,
<thomas.petazzoni@bootlin.com>, Neal Frager <neal.frager@amd.com>
Subject: [PATCH v3 1/1] configure.ac: configurable tooldir install path
Date: Thu, 11 Jan 2024 10:50:27 +0000 [thread overview]
Message-ID: <20240111105027.3382376-1-neal.frager@amd.com> (raw)
This patch is required to fix how the newlib headers are installed
when using a sysroot install directory.
The cross compiler expects headers to be in
.../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
by default newlib installed the headers into
.../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h
${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
${target_noncanonical} provides an extra arm-none-eabi/ that must be removed.
With this patch, users can specify the tooldir path that is needed.
Signed-off-by: Neal Frager <neal.frager@amd.com>
Co-developed-by: Chris Wardman <cjwfirmware@vxmdesign.com>
---
V1->V2:
- migrated patch to configure.ac
- changed option name to --with-tooldir=PATH
V2->V3;
- removed quotes around ${with_tooldir}
---
configure.ac | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f1bb72100..8ca8cf9fe 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2599,7 +2599,18 @@ esac
# Some systems (e.g., one of the i386-aix systems the gas testers are
# using) don't handle "\$" correctly, so don't use it here.
-tooldir='${exec_prefix}'/${target_noncanonical}
+AC_ARG_WITH([tooldir],
+ [AS_HELP_STRING([--with-tooldir=PATH],
+ [use given path to install target tools after build])],
+ [case x"$withval" in
+ x/*) ;;
+ *)
+ with_tooldir=
+ AC_MSG_WARN([argument to --with-tooldir must be an absolute path])
+ ;;
+ esac],
+ [with_tooldir='${exec_prefix}'/${target_noncanonical}])
+tooldir=${with_tooldir}
build_tooldir=${tooldir}
# Create a .gdbinit file which runs the one in srcdir
--
2.25.1
next prev reply other threads:[~2024-01-11 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 9:55 [PATCH v1 1/1] configure: correct " Neal Frager
2023-12-15 10:33 ` Thomas Petazzoni
2023-12-15 12:08 ` Frager, Neal
2023-12-15 17:07 ` Thomas Petazzoni
2024-01-03 22:43 ` Jeff Johnston
2024-01-11 10:50 ` Neal Frager [this message]
2024-01-11 15:41 ` [PATCH v3 1/1] configure.ac: configurable " Mike Frysinger
2024-01-11 16:22 ` Frager, Neal
2024-01-11 17:07 ` [PATCH v4 " Neal Frager
2024-01-11 17:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111105027.3382376-1-neal.frager@amd.com \
--to=neal.frager@amd.com \
--cc=cjwfirmware@vxmdesign.com \
--cc=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).