From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Frager, Neal" <neal.frager@amd.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>,
"cjwfirmware@vxmdesign.com" <cjwfirmware@vxmdesign.com>
Subject: Re: [PATCH v1 1/1] configure: correct tooldir install path
Date: Fri, 15 Dec 2023 18:07:38 +0100 [thread overview]
Message-ID: <20231215180738.4fde7cb9@windsurf> (raw)
In-Reply-To: <CH2PR12MB50043E711DCB06FD78129A32F093A@CH2PR12MB5004.namprd12.prod.outlook.com>
On Fri, 15 Dec 2023 12:08:37 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> > The configure script is generated from configure.ac, so you should not
> > patch configure but configure.ac.
>
> When building newlib, I am not seeing the configure script get
> generated. If I only patch configure.ac, the configure script stays
> the same and my patch appears ignored.
>
> Do you know what I could be missing?
Yes, you need to learn/read a bit about the autotools, and autoconf in
particular :-)
> I made this correction, and the --with-tooldir option only works
> if I patch it directly into the configure script.
>
> Could you help me figure out what is missing?
See above :-)
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
next prev parent reply other threads:[~2023-12-15 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 9:55 Neal Frager
2023-12-15 10:33 ` Thomas Petazzoni
2023-12-15 12:08 ` Frager, Neal
2023-12-15 17:07 ` Thomas Petazzoni [this message]
2024-01-03 22:43 ` Jeff Johnston
2024-01-11 10:50 ` [PATCH v3 1/1] configure.ac: configurable " Neal Frager
2024-01-11 15:41 ` Mike Frysinger
2024-01-11 16:22 ` Frager, Neal
2024-01-11 17:07 ` [PATCH v4 " Neal Frager
2024-01-11 17:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215180738.4fde7cb9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=cjwfirmware@vxmdesign.com \
--cc=neal.frager@amd.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).