From: "Frager, Neal" <neal.frager@amd.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>,
"cjwfirmware@vxmdesign.com" <cjwfirmware@vxmdesign.com>
Subject: RE: [PATCH v1 1/1] configure: correct tooldir install path
Date: Fri, 15 Dec 2023 12:08:37 +0000 [thread overview]
Message-ID: <CH2PR12MB50043E711DCB06FD78129A32F093A@CH2PR12MB5004.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231215113332.4a0fd114@windsurf>
Hi Thomas,
> This patch is required to fix how the newlib headers are installed
> when using a sysroot install directory.
>
> The cross compiler expects headers to be in
> .../host/usr/arm-none-eabi/sysroot/usr/include/newlib.h
> by default newlib installed the headers into
> .../host/usr/arm-none-eabi/sysroot/usr/arm-none-eabi/include/newlib.h
>
> ${exec_prefix} provides the .../host/usr/arm-none-eabi/sysroot path
> ${target_noncanonical} provides an extra arm-none-eabi/ that must be removed.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Co-developed-by: Chris Wardman <cjwfirmware@vxmdesign.com>
> ---
> configure | 7 +++++++
> 1 file changed, 7 insertions(+)
> The configure script is generated from configure.ac, so you should not
> patch configure but configure.ac.
When building newlib, I am not seeing the configure script get
generated. If I only patch configure.ac, the configure script stays
the same and my patch appears ignored.
Do you know what I could be missing?
> + --with-install-sysroot use sysroot install directory
> --with-debug-prefix-map='A=B C=D ...'
> map A to B, C to D ... in debug information
> --with-build-config='NAME NAME2...'
> @@ -7057,7 +7059,12 @@ esac
>
> # Some systems (e.g., one of the i386-aix systems the gas testers are
> # using) don't handle "\$" correctly, so don't use it here.
> +# Check whether --with-install-sysroot was given.
> +if test "${with_install_sysroot+set}" = set; then :
> --with/--without options are usually not used for boolean things,
> instead --enable/--disable option are used for boolean things.
> However here, I think that what would make sense is a --with-tooldir
> option. When not passed, the value is
> '${exec_prefix}'/${target_noncanonical}, and when passed, the value is
> the one passed in the option:
> ./configure ... --with-tooldir=/blabla
I made this correction, and the --with-tooldir option only works
if I patch it directly into the configure script.
Could you help me figure out what is missing?
Best regards,
Neal Frager
AMD
next prev parent reply other threads:[~2023-12-15 12:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 9:55 Neal Frager
2023-12-15 10:33 ` Thomas Petazzoni
2023-12-15 12:08 ` Frager, Neal [this message]
2023-12-15 17:07 ` Thomas Petazzoni
2024-01-03 22:43 ` Jeff Johnston
2024-01-11 10:50 ` [PATCH v3 1/1] configure.ac: configurable " Neal Frager
2024-01-11 15:41 ` Mike Frysinger
2024-01-11 16:22 ` Frager, Neal
2024-01-11 17:07 ` [PATCH v4 " Neal Frager
2024-01-11 17:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB50043E711DCB06FD78129A32F093A@CH2PR12MB5004.namprd12.prod.outlook.com \
--to=neal.frager@amd.com \
--cc=cjwfirmware@vxmdesign.com \
--cc=newlib@sourceware.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).