public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: "Frager, Neal" <neal.frager@amd.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>,
	"cjwfirmware@vxmdesign.com" <cjwfirmware@vxmdesign.com>,
	"jjohnstn@redhat.com" <jjohnstn@redhat.com>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>
Subject: RE: [PATCH v3 1/1] configure.ac: configurable tooldir install path
Date: Thu, 11 Jan 2024 16:22:35 +0000	[thread overview]
Message-ID: <CH2PR12MB500456A16BAEEC32E9190C4BF0682@CH2PR12MB5004.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ZaAMIoZif1xKJ4ZH@vapier>

Hi Mike,

Thank you for your feedback.

> +  [case x"$withval" in

> use AS_CASE

Ok.

> +	x/*) ;;
> +	*)
> +	with_tooldir=
> +	AC_MSG_WARN([argument to --with-tooldir must be an absolute path])

> shouldn't this be AC_MSG_ERROR ?  otherwise you're leaving it unset below.
> -mike

Yes, good point.  If the user does not use an absolute
path, this should trigger an error and not just a warning.

I will make these changes in v4.

Best regards,
Neal Frager
AMD

  reply	other threads:[~2024-01-11 16:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  9:55 [PATCH v1 1/1] configure: correct " Neal Frager
2023-12-15 10:33 ` Thomas Petazzoni
2023-12-15 12:08   ` Frager, Neal
2023-12-15 17:07     ` Thomas Petazzoni
2024-01-03 22:43     ` Jeff Johnston
2024-01-11 10:50 ` [PATCH v3 1/1] configure.ac: configurable " Neal Frager
2024-01-11 15:41   ` Mike Frysinger
2024-01-11 16:22     ` Frager, Neal [this message]
2024-01-11 17:07 ` [PATCH v4 " Neal Frager
2024-01-11 17:25   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CH2PR12MB500456A16BAEEC32E9190C4BF0682@CH2PR12MB5004.namprd12.prod.outlook.com \
    --to=neal.frager@amd.com \
    --cc=cjwfirmware@vxmdesign.com \
    --cc=jjohnstn@redhat.com \
    --cc=newlib@sourceware.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).