From: Jon Turney <jon.turney@dronecode.org.uk>
To: Brian Inglis <Brian.Inglis@Shaw.ca>,
"newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues
Date: Mon, 20 Feb 2023 22:03:00 +0000 [thread overview]
Message-ID: <381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk> (raw)
In-Reply-To: <b6aa6bf3-e3d2-0220-a39c-9577ad6c471e@Shaw.ca>
On 20/02/2023 20:25, Brian Inglis wrote:
> On 2023-02-20 02:45, Corinna Vinschen wrote:
>> Hi Brian,
>>
>> On Feb 17 13:49, Brian Inglis wrote:
>>> Brian Inglis (2):
>>> newlib/libc/time/strftime.c: split table of conversion
>>> specifiers to fix man, tbl, groff multi-page table issues
>>> newlib/libc/Makefile.inc: sed fix strftime.3 table format
>>> man, tbl, groff multi-page issues
>>>
>>> newlib/libc/time/strftime.c | 3 ++-
>>> newlib/libc/Makefile.inc | 1 +
>>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>>
>>> --
>>> 2.39.0
>>
>> Would you mind terribly to add more text to the commit messages?
>> explaining the problem, and its fix? Just the subject line is quite
>> terse.
>>
>> For patch 1, why adding the split and what's the desired effect. For
>> patch 2, what problem is the sed call fixing and what is the sed
>> expression doing?
>
> Thanks Corinna, You're right - will redo all v3.
You should also describe why this must be fixed in this ad-hoc fasion,
rather than in the chew markup or makedocbook.
next prev parent reply other threads:[~2023-02-20 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 20:49 Brian Inglis
2023-02-17 20:49 ` [PATCH 1/2] newlib/libc/time/strftime.c: split table of conversion specifiers to " Brian Inglis
2023-02-17 20:49 ` [PATCH 2/2] newlib/libc/Makefile.inc: sed fix strftime.3 table format man, tbl, groff multi-page issues Brian Inglis
2023-02-18 16:54 ` [PATCH v2 " Brian Inglis
2023-02-20 9:45 ` [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues Corinna Vinschen
2023-02-20 20:25 ` Brian Inglis
2023-02-20 22:03 ` Jon Turney [this message]
2023-02-20 23:20 ` Brian Inglis
2023-02-22 20:10 ` Jon Turney
2023-02-23 15:12 ` Brian Inglis
2023-02-21 4:17 ` [PATCH v3 0/2] newlib/libc/time/strftime: fix multi-page table format issues Brian Inglis
2023-02-21 4:18 ` [PATCH v3 1/2] newlib/libc/time/strftime.c: split chew table of conversion format specifiers Brian Inglis
2023-02-21 4:18 ` [PATCH v3 2/2] newlib/libc/Makefile.inc: sed fix strftime.3 tbl/groff format issues Brian Inglis
2023-02-21 9:15 ` [PATCH v3 0/2] newlib/libc/time/strftime: fix multi-page table " Corinna Vinschen
2023-02-22 20:10 ` Jon Turney
2023-02-23 0:03 ` Brian Inglis
2023-02-23 15:33 ` Brian Inglis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=381ec8a8-1809-0eba-6321-f9cb32143995@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Brian.Inglis@Shaw.ca \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).