Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues

[Brian Inglis <Brian.Inglis@Shaw.ca>]

On 2023-02-20 02:45, Corinna Vinschen wrote:
> Hi Brian,
> 
> On Feb 17 13:49, Brian Inglis wrote:
>> Brian Inglis (2):
>>    newlib/libc/time/strftime.c: split table of conversion
>>      specifiers to fix man, tbl, groff multi-page table issues
>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format
>>      man, tbl, groff multi-page issues
>>
>>   newlib/libc/time/strftime.c | 3 ++-
>>   newlib/libc/Makefile.inc    | 1 +
>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> --
>> 2.39.0
> 
> Would you mind terribly to add more text to the commit messages?
> explaining the problem, and its fix?  Just the subject line is quite
> terse.
> 
> For patch 1, why adding the split and what's the desired effect.  For
> patch 2, what problem is the sed call fixing and what is the sed
> expression doing?

Thanks Corinna, You're right - will redo all v3.

-- 
Take care. Thanks, Brian Inglis			Calgary, Alberta, Canada

La perfection est atteinte			Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter	not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer	but when there is no more to cut
			-- Antoine de Saint-Exupéry