Re: [PATCH 0/2] newlib/libc/time/strftime: table format fix man, tbl, groff multi-page table issues

[Brian Inglis <Brian.Inglis@Shaw.ca>]

On 2023-02-20 15:03, Jon Turney wrote:
> On 20/02/2023 20:25, Brian Inglis wrote:
>> On 2023-02-20 02:45, Corinna Vinschen wrote:
>>> Hi Brian,
>>>
>>> On Feb 17 13:49, Brian Inglis wrote:
>>>> Brian Inglis (2):
>>>>    newlib/libc/time/strftime.c: split table of conversion
>>>>      specifiers to fix man, tbl, groff multi-page table issues
>>>>    newlib/libc/Makefile.inc: sed fix strftime.3 table format
>>>>      man, tbl, groff multi-page issues
>>>>
>>>>   newlib/libc/time/strftime.c | 3 ++-
>>>>   newlib/libc/Makefile.inc    | 1 +
>>>>   2 files changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> -- 
>>>> 2.39.0
>>>
>>> Would you mind terribly to add more text to the commit messages?
>>> explaining the problem, and its fix?  Just the subject line is quite
>>> terse.
>>>
>>> For patch 1, why adding the split and what's the desired effect.  For
>>> patch 2, what problem is the sed call fixing and what is the sed
>>> expression doing?
>>
>> Thanks Corinna, You're right - will redo all v3.
> 
> You should also describe why this must be fixed in this ad-hoc fasion, rather 
> than in the chew markup or makedocbook.

I'll also ref the discussion with Branden, following comments from linux-man,
the newlib man generation by docbook2man is incompatible with how man is 
incompatible with groff/tbl/grohtml:

https://lists.gnu.org/archive/html/bug-groff/2023-02/msg00118.html

I dug and could not find a good point to alter generation of tables > page size 
that may not adversely affect other [newlib] doc man page tables, where the 
problem occurs solely on that strftime.3 man page!

Also the imminent groff/tbl/grohtml release fixes a number of tbl issues, so may 
affect man pages with tables differently.

The following release plans to change grohtml, from generating tables as PNG 
graphics, which don't work on some output "devices"/file formats, and are not 
searchable, to generating tables in searchable text form on the target 
"devices"/file formats, so will also affect man pages with tables differently, 
and fix other related issues.

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry