From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: [HEADSUP] Re: [PATCH] newlib: libm: merge build up a directory
Date: Wed, 16 Feb 2022 23:38:43 -0500 [thread overview]
Message-ID: <Yg3RUwXnmoeOIVKp@vapier> (raw)
In-Reply-To: <Ygy6xH1jVtp0apWe@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]
On 16 Feb 2022 09:50, Corinna Vinschen wrote:
> On Feb 12 15:34, Mike Frysinger wrote:
> > Convert all the libm/ subdir makes into the top-level Makefile. This
> > allows us to build all of libm from the top Makefile without using any
> > recursive make calls. This is faster and avoids the funky lib.a logic
> > where we unpack subdir archives to repack into a single libm.a. The
> > machine override logic is maintained though by way of Makefile include
> > ordering, and source file accumulation in libm_a_SOURCES.
>
> What targets did you test this with?
testing these targets:
aarch64-elf arc-elf arm-eabi
bfin-elf
cr16-elf cris-elf csky-elf
epiphany-elf
frv-elf
h8300-elf
i386-elf i686-pc-cygwin iq2000-elf
m68k-elf microblaze-elf mips-elf mn10300-elf moxie-elf
nds32le-elf
or1k-elf
powerpc-elf
sparc-elf sparc-rtems
v850e-elf visium-elf
xstormy16-elf
the actual testing:
- build w/out the patch
make install DESTDIR=$PWD/old.root
ar t every library
objdump -d every object
- build w/the patch
make install DESTDIR=$PWD/new.root
ar t every library
objdump -d every object
run `diff -ur` on the 2 roots. they install the same set of files, and
the disassembly of the objects is the same.
so should be good to go. only needed about 30G to determine this :p.
> > One thing to note is that this will require GNU Make because of:
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Anybody here having a problem with that?
while i couldn't find any prior usage in newlib specifically (i think all
the code i looked through is portable make), libgloss def has GNUisms in
at least 12 of its ports:
aarch64 arm bfin cris csky m68k msp430 nios2 or1k riscv visium xstormy16
no one seems to have complained so far :).
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-17 4:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 20:34 Mike Frysinger
2022-02-16 8:50 ` [HEADSUP] " Corinna Vinschen
2022-02-16 9:40 ` Sebastian Huber
2022-02-16 10:48 ` Corinna Vinschen
2022-02-17 4:38 ` Mike Frysinger [this message]
2022-02-17 4:42 ` [PATCH v2] " Mike Frysinger
2022-02-17 12:08 ` Corinna Vinschen
2022-02-21 11:20 ` Corinna Vinschen
2022-02-21 18:00 ` Mike Frysinger
2022-02-21 18:04 ` Jon Turney
2022-02-21 18:30 ` Mike Frysinger
2022-02-21 19:12 ` Jon Turney
2022-02-21 19:24 ` Corinna Vinschen
2022-02-21 20:30 ` Mike Frysinger
2022-02-21 20:31 ` Mike Frysinger
2022-02-21 18:28 ` Mike Frysinger
2022-02-21 20:43 ` [PATCH] newlib: libm: workaround ar duplicate member behavior Mike Frysinger
2022-02-21 20:51 ` Joel Sherrill
2022-02-21 22:12 ` Mike Frysinger
2022-02-21 22:14 ` Joel Sherrill
2022-02-22 0:21 ` [PATCH v2] " Mike Frysinger
2022-02-22 11:31 ` Corinna Vinschen
2022-02-22 12:34 ` Jon Turney
2022-02-22 17:17 ` Mike Frysinger
2022-02-23 8:56 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg3RUwXnmoeOIVKp@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).