Re: [PATCH v2] newlib: libm: merge build up a directory

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1537 bytes --]

On 21 Feb 2022 20:24, Corinna Vinschen wrote:
> On Feb 21 19:12, Jon Turney wrote:
> > On 21/02/2022 18:30, Mike Frysinger wrote:
> > > > > > 
> > > > > > Can you please take a look?
> > > > > 
> > > > > how do you build cygwin ?  i've just been doing w/newlib-cygwin git checkout:
> > > > > $ ./configure --target=i686-pc-cygwin && make
> > > > > $ ./configure --target=x86_64-pc-cygwin && make
> > > > > these are passing for me
> > > > 
> > > > You'll need to apply this patch:
> > > > 
> > > > https://cygwin.com/pipermail/cygwin-patches/2022q1/011766.html
> > > > 
> > > > Otherwise, you are linking with a stale libm.a left in your builddir
> > > > from before these changes.
> > > 
> > > while i often test incremental changes, i `rm -rf` the build dir when running
> > > the full test suite to avoid possible issues like this.  and in this case,
> > > both targets pass from a fresh build.
> > 
> > Have you run autogen.sh in the winsup/ directory?  The top-level will just
> > ignore it if there is no ./configure there, and it's not checked in.
> 
> Also, always build in an external build dir.  This may not be a problem
> anymore, but in the olden days a build in the sourcedir was broken.

i always build in sep dir since i'm building ~30 targets in parallel

looks like i needed -U_FORTIFY_SOURCE and --with-cross-bootstrap too.
my patch for libm.a fixes linking of the dll files afaict.  there's
some build errors in the docs that i don't understand, but they don't
seem relevant.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]