From: Corinna Vinschen <vinschen@redhat.com>
To: jiawei <jiawei@iscas.ac.cn>
Cc: newlib@sourceware.org, maxim.blinov@embecosm.com,
msebor@redhat.com, wuwei2016@iscas.ac.cn, palmer@dabbelt.com,
kito.cheng@sifive.com
Subject: Re: [PATCH] newlib: libc: reente.h: remove unnecessary parentheses
Date: Wed, 18 May 2022 12:39:23 +0200 [thread overview]
Message-ID: <YoTM2wYj4ZIxreSQ@calimero.vinschen.de> (raw)
In-Reply-To: <20220518100318.890201-1-jiawei@iscas.ac.cn>
On May 18 18:03, jiawei wrote:
> From: Jia-Wei Chen <jiawei@iscas.ac.cn>
>
> The compiler warns the double parentheses are unnecessary in some
> target, and cause fail cases when doing some testcases in regression.
>
> gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C
>
> Remove the unnecessary parentheses will fix it. See more details in
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85775
>
> Same like in commit 05425831290c9869bc7987b5df3ce84aa4f19a6c,
> Author: Maxim Blinov <maxim.blinov@embecosm.com>
> Date: Thu Jul 22 22:41:42 2021 +0100
>
> Remove unneccesary parenthesis around declarator
>
> Thanks for Sebastian Huber's remind!
>
> ChangeLog:
>
> * newlib/libc/include/sys/reent.h (struct _reent): Remove
> * additonal parentheses.
Pushed with fixed subject and dropping tne CVS-style entry in the commit
message. We don't do CVS anymore these days :)
Thanks,
Corinna
prev parent reply other threads:[~2022-05-18 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 10:03 jiawei
2022-05-18 10:39 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoTM2wYj4ZIxreSQ@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=jiawei@iscas.ac.cn \
--cc=kito.cheng@sifive.com \
--cc=maxim.blinov@embecosm.com \
--cc=msebor@redhat.com \
--cc=newlib@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=wuwei2016@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).