[PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

---
 newlib/MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
index 6117ff4..0bd93ff 100644
--- a/newlib/MAINTAINERS
+++ b/newlib/MAINTAINERS
@@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
 msp430			DJ Delorie		dj@redhat.com
 			Nick Clifton		nickc@redhat.com
 
+			OS Port Maintainers	(OS alphabetical order)
+
+OS port maintainers may make changes in OS-specific directories, as
+well as OS-specific portions of the build system, without approval.
+
+RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
 
 			Write After Approval
 
@@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
 Eric Blake			eblake@redhat.com
 Will Newton			will.newton@linaro.org
 Sebastian Huber			sebastian.huber@embedded-brains.de
+Joel Sherrill			joel.sherrill@oarcorp.com
-- 
1.8.3.1

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Jun 13 16:30, Joel Sherrill wrote:
> ---
>  newlib/MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
> index 6117ff4..0bd93ff 100644
> --- a/newlib/MAINTAINERS
> +++ b/newlib/MAINTAINERS
> @@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
>  msp430			DJ Delorie		dj@redhat.com
>  			Nick Clifton		nickc@redhat.com
>  
> +			OS Port Maintainers	(OS alphabetical order)
> +
> +OS port maintainers may make changes in OS-specific directories, as
> +well as OS-specific portions of the build system, without approval.
> +
> +RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
>  
>  			Write After Approval
>  
> @@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
>  Eric Blake			eblake@redhat.com
>  Will Newton			will.newton@linaro.org
>  Sebastian Huber			sebastian.huber@embedded-brains.de
> +Joel Sherrill			joel.sherrill@oarcorp.com
> -- 
> 1.8.3.1

On hold.  I'm still discussing this with Jeff.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Jeff Johnston]

It would have been nicer to ask first, but that said, I am ok with a
clarification added to the definition.

For an OS maintainer, changes that add OS-specific changes to existing
shared files need approval.  That means you may
make changes to an existing RTEMS section of a header file, but you cannot
add an RTEMS section to a
header or source file that did not have such a section without approval.  I
don't want to have RTEMS stuff added all over the
place to save you having to have your own version in your directory.

-- Jeff J.

On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
> On Jun 13 16:30, Joel Sherrill wrote:
>> ---
>>  newlib/MAINTAINERS | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
>> index 6117ff4..0bd93ff 100644
>> --- a/newlib/MAINTAINERS
>> +++ b/newlib/MAINTAINERS
>> @@ -45,6 +45,12 @@ aarch64                    Richard Earnshaw        richard.earnshaw@arm.com
>>  msp430                       DJ Delorie              dj@redhat.com
>>                       Nick Clifton            nickc@redhat.com
>>
>> +                     OS Port Maintainers     (OS alphabetical order)
>> +
>> +OS port maintainers may make changes in OS-specific directories, as
>> +well as OS-specific portions of the build system, without approval.
>> +
>> +RTEMS                        Joel Sherrill           joel.sherrill@oarcorp.com
>>
>>                       Write After Approval
>>
>> @@ -57,3 +63,4 @@ Nick Clifton                        nickc@redhat.com
>>  Eric Blake                   eblake@redhat.com
>>  Will Newton                  will.newton@linaro.org
>>  Sebastian Huber                      sebastian.huber@embedded-brains.de
>> +Joel Sherrill                        joel.sherrill@oarcorp.com
>> --
>> 1.8.3.1
>
> On hold.  I'm still discussing this with Jeff.
>
>
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

On 6/14/2017 10:49 AM, Jeff Johnston wrote:
> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.
> 
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval.  That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval.  I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.

It wasn't a power grab and I am sorry if it was perceived as such.
I didn't intend it to change anything in how anyone in the RTEMS
community approached newlib. We have been users for since before
1995 and have always submitted patches for review before merging.
I am pretty sure I have had the equivalent of write after approval
for 20 years.

I viewed updating that as contact information and a reflection
of existing practice. I post patches and wait for approval
(even for RTEMS specific parts) before committing.

I agree 100% that caution should be exercised when touching
common files. At the same time, sharing common source/header
files has value so it is worth posting patches and going
back and forth.

Again I apologize that more was read into that patch than
was intended.

--joel

> 
> -- Jeff J.
> 
> On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jun 13 16:30, Joel Sherrill wrote:
>>> ---
>>>   newlib/MAINTAINERS | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
>>> index 6117ff4..0bd93ff 100644
>>> --- a/newlib/MAINTAINERS
>>> +++ b/newlib/MAINTAINERS
>>> @@ -45,6 +45,12 @@ aarch64                    Richard Earnshaw        richard.earnshaw@arm.com
>>>   msp430                       DJ Delorie              dj@redhat.com
>>>                        Nick Clifton            nickc@redhat.com
>>>
>>> +                     OS Port Maintainers     (OS alphabetical order)
>>> +
>>> +OS port maintainers may make changes in OS-specific directories, as
>>> +well as OS-specific portions of the build system, without approval.
>>> +
>>> +RTEMS                        Joel Sherrill           joel.sherrill@oarcorp.com
>>>
>>>                        Write After Approval
>>>
>>> @@ -57,3 +63,4 @@ Nick Clifton                        nickc@redhat.com
>>>   Eric Blake                   eblake@redhat.com
>>>   Will Newton                  will.newton@linaro.org
>>>   Sebastian Huber                      sebastian.huber@embedded-brains.de
>>> +Joel Sherrill                        joel.sherrill@oarcorp.com
>>> --
>>> 1.8.3.1
>>
>> On hold.  I'm still discussing this with Jeff.
>>
>>
>> Corinna
>>
>> --
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Sebastian Huber]

On 14/06/17 17:49, Jeff Johnston wrote:

> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.

Sorry for the confusion. Since Newlib had already the concept of CPU 
Port Maintainers and GCC has CPU/OS Port Maintainers I thought that the 
OS Port Maintainers section was just missing when I looked at this file 
to add myself to Write After Approval. Joel was missing too, so it 
seemed to me that this file was not up to date in general.

>
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval.  That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval.  I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.

I think this is clearly stated by:

"            OS Port Maintainers    (OS alphabetical order)

OS port maintainers may make changes in OS-specific directories, as
well as OS-specific portions of the build system, without approval."

My goal is to get rid of all the __rtems__ defines in shared files.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

[PATCH 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS

[Joel Sherrill]

The *-*-rtems* targets defined this even though the conditional
was no longer present in i386/setjmp.S.
---
 newlib/configure.host | 2 --
 1 file changed, 2 deletions(-)

diff --git a/newlib/configure.host b/newlib/configure.host
index ba2d8c6..fb3362b 100644
--- a/newlib/configure.host
+++ b/newlib/configure.host
@@ -608,8 +608,6 @@ case "${host}" in
 	newlib_cflags="${newlib_cflags} -DCLOCK_PROVIDED -DMALLOC_PROVIDED -DEXIT_PROVIDED -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_NANOSLEEP -DHAVE_BLKSIZE -DHAVE_FCNTL -DHAVE_ASSERT_FUNC"
         # turn off unsupported items in posix directory 
 	newlib_cflags="${newlib_cflags} -D_NO_GETLOGIN -D_NO_GETPWENT -D_NO_GETUT -D_NO_GETPASS -D_NO_SIGSET -D_NO_WORDEXP -D_NO_POPEN -D_NO_POSIX_SPAWN"
-        # turn off using cli/sti in i386 setjmp/longjmp
-	newlib_cflags="${newlib_cflags} -D_I386MACH_ALLOW_HW_INTERRUPTS"
 	;;
 # VxWorks supplies its own version of malloc, and the newlib one
 # doesn't work because VxWorks does not have sbrk.
-- 
1.8.3.1

[PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

---
 newlib/MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
index 6117ff4..0bd93ff 100644
--- a/newlib/MAINTAINERS
+++ b/newlib/MAINTAINERS
@@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
 msp430			DJ Delorie		dj@redhat.com
 			Nick Clifton		nickc@redhat.com
 
+			OS Port Maintainers	(OS alphabetical order)
+
+OS port maintainers may make changes in OS-specific directories, as
+well as OS-specific portions of the build system, without approval.
+
+RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
 
 			Write After Approval
 
@@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
 Eric Blake			eblake@redhat.com
 Will Newton			will.newton@linaro.org
 Sebastian Huber			sebastian.huber@embedded-brains.de
+Joel Sherrill			joel.sherrill@oarcorp.com
-- 
1.8.3.1

Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.

[Joel Sherrill]

Ignore this. It was just laying around and git send-email
picked it up. It has already been discussed and merged.

On 10/10/2017 9:36 AM, Joel Sherrill wrote:
> ---
>   newlib/MAINTAINERS | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
> index 6117ff4..0bd93ff 100644
> --- a/newlib/MAINTAINERS
> +++ b/newlib/MAINTAINERS
> @@ -45,6 +45,12 @@ aarch64			Richard Earnshaw	richard.earnshaw@arm.com
>   msp430			DJ Delorie		dj@redhat.com
>   			Nick Clifton		nickc@redhat.com
>   
> +			OS Port Maintainers	(OS alphabetical order)
> +
> +OS port maintainers may make changes in OS-specific directories, as
> +well as OS-specific portions of the build system, without approval.
> +
> +RTEMS			Joel Sherrill		joel.sherrill@oarcorp.com
>   
>   			Write After Approval
>   
> @@ -57,3 +63,4 @@ Nick Clifton			nickc@redhat.com
>   Eric Blake			eblake@redhat.com
>   Will Newton			will.newton@linaro.org
>   Sebastian Huber			sebastian.huber@embedded-brains.de
> +Joel Sherrill			joel.sherrill@oarcorp.com
> 

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35806
Support Available                (256) 722-9985