* [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
@ 2017-06-13 19:31 Joel Sherrill
2017-06-14 8:50 ` Corinna Vinschen
0 siblings, 1 reply; 7+ messages in thread
From: Joel Sherrill @ 2017-06-13 19:31 UTC (permalink / raw)
To: newlib; +Cc: Joel Sherrill
---
newlib/MAINTAINERS | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
index 6117ff4..0bd93ff 100644
--- a/newlib/MAINTAINERS
+++ b/newlib/MAINTAINERS
@@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
msp430 DJ Delorie dj@redhat.com
Nick Clifton nickc@redhat.com
+ OS Port Maintainers (OS alphabetical order)
+
+OS port maintainers may make changes in OS-specific directories, as
+well as OS-specific portions of the build system, without approval.
+
+RTEMS Joel Sherrill joel.sherrill@oarcorp.com
Write After Approval
@@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
Eric Blake eblake@redhat.com
Will Newton will.newton@linaro.org
Sebastian Huber sebastian.huber@embedded-brains.de
+Joel Sherrill joel.sherrill@oarcorp.com
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-06-13 19:31 [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval Joel Sherrill
@ 2017-06-14 8:50 ` Corinna Vinschen
2017-06-14 15:49 ` Jeff Johnston
0 siblings, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2017-06-14 8:50 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Jun 13 16:30, Joel Sherrill wrote:
> ---
> newlib/MAINTAINERS | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
> index 6117ff4..0bd93ff 100644
> --- a/newlib/MAINTAINERS
> +++ b/newlib/MAINTAINERS
> @@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
> msp430 DJ Delorie dj@redhat.com
> Nick Clifton nickc@redhat.com
>
> + OS Port Maintainers (OS alphabetical order)
> +
> +OS port maintainers may make changes in OS-specific directories, as
> +well as OS-specific portions of the build system, without approval.
> +
> +RTEMS Joel Sherrill joel.sherrill@oarcorp.com
>
> Write After Approval
>
> @@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
> Eric Blake eblake@redhat.com
> Will Newton will.newton@linaro.org
> Sebastian Huber sebastian.huber@embedded-brains.de
> +Joel Sherrill joel.sherrill@oarcorp.com
> --
> 1.8.3.1
On hold. I'm still discussing this with Jeff.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-06-14 8:50 ` Corinna Vinschen
@ 2017-06-14 15:49 ` Jeff Johnston
2017-06-14 16:07 ` Joel Sherrill
2017-06-22 8:06 ` Sebastian Huber
0 siblings, 2 replies; 7+ messages in thread
From: Jeff Johnston @ 2017-06-14 15:49 UTC (permalink / raw)
To: Newlib
It would have been nicer to ask first, but that said, I am ok with a
clarification added to the definition.
For an OS maintainer, changes that add OS-specific changes to existing
shared files need approval. That means you may
make changes to an existing RTEMS section of a header file, but you cannot
add an RTEMS section to a
header or source file that did not have such a section without approval. I
don't want to have RTEMS stuff added all over the
place to save you having to have your own version in your directory.
-- Jeff J.
On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
> On Jun 13 16:30, Joel Sherrill wrote:
>> ---
>> newlib/MAINTAINERS | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
>> index 6117ff4..0bd93ff 100644
>> --- a/newlib/MAINTAINERS
>> +++ b/newlib/MAINTAINERS
>> @@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
>> msp430 DJ Delorie dj@redhat.com
>> Nick Clifton nickc@redhat.com
>>
>> + OS Port Maintainers (OS alphabetical order)
>> +
>> +OS port maintainers may make changes in OS-specific directories, as
>> +well as OS-specific portions of the build system, without approval.
>> +
>> +RTEMS Joel Sherrill joel.sherrill@oarcorp.com
>>
>> Write After Approval
>>
>> @@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
>> Eric Blake eblake@redhat.com
>> Will Newton will.newton@linaro.org
>> Sebastian Huber sebastian.huber@embedded-brains.de
>> +Joel Sherrill joel.sherrill@oarcorp.com
>> --
>> 1.8.3.1
>
> On hold. I'm still discussing this with Jeff.
>
>
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-06-14 15:49 ` Jeff Johnston
@ 2017-06-14 16:07 ` Joel Sherrill
2017-06-22 8:06 ` Sebastian Huber
1 sibling, 0 replies; 7+ messages in thread
From: Joel Sherrill @ 2017-06-14 16:07 UTC (permalink / raw)
To: Jeff Johnston, Newlib
On 6/14/2017 10:49 AM, Jeff Johnston wrote:
> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.
>
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval. That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval. I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.
It wasn't a power grab and I am sorry if it was perceived as such.
I didn't intend it to change anything in how anyone in the RTEMS
community approached newlib. We have been users for since before
1995 and have always submitted patches for review before merging.
I am pretty sure I have had the equivalent of write after approval
for 20 years.
I viewed updating that as contact information and a reflection
of existing practice. I post patches and wait for approval
(even for RTEMS specific parts) before committing.
I agree 100% that caution should be exercised when touching
common files. At the same time, sharing common source/header
files has value so it is worth posting patches and going
back and forth.
Again I apologize that more was read into that patch than
was intended.
--joel
>
> -- Jeff J.
>
> On Wed, Jun 14, 2017 at 4:50 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Jun 13 16:30, Joel Sherrill wrote:
>>> ---
>>> newlib/MAINTAINERS | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
>>> index 6117ff4..0bd93ff 100644
>>> --- a/newlib/MAINTAINERS
>>> +++ b/newlib/MAINTAINERS
>>> @@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
>>> msp430 DJ Delorie dj@redhat.com
>>> Nick Clifton nickc@redhat.com
>>>
>>> + OS Port Maintainers (OS alphabetical order)
>>> +
>>> +OS port maintainers may make changes in OS-specific directories, as
>>> +well as OS-specific portions of the build system, without approval.
>>> +
>>> +RTEMS Joel Sherrill joel.sherrill@oarcorp.com
>>>
>>> Write After Approval
>>>
>>> @@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
>>> Eric Blake eblake@redhat.com
>>> Will Newton will.newton@linaro.org
>>> Sebastian Huber sebastian.huber@embedded-brains.de
>>> +Joel Sherrill joel.sherrill@oarcorp.com
>>> --
>>> 1.8.3.1
>>
>> On hold. I'm still discussing this with Jeff.
>>
>>
>> Corinna
>>
>> --
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-06-14 15:49 ` Jeff Johnston
2017-06-14 16:07 ` Joel Sherrill
@ 2017-06-22 8:06 ` Sebastian Huber
1 sibling, 0 replies; 7+ messages in thread
From: Sebastian Huber @ 2017-06-22 8:06 UTC (permalink / raw)
To: newlib
On 14/06/17 17:49, Jeff Johnston wrote:
> It would have been nicer to ask first, but that said, I am ok with a
> clarification added to the definition.
Sorry for the confusion. Since Newlib had already the concept of CPU
Port Maintainers and GCC has CPU/OS Port Maintainers I thought that the
OS Port Maintainers section was just missing when I looked at this file
to add myself to Write After Approval. Joel was missing too, so it
seemed to me that this file was not up to date in general.
>
> For an OS maintainer, changes that add OS-specific changes to existing
> shared files need approval. That means you may
> make changes to an existing RTEMS section of a header file, but you cannot
> add an RTEMS section to a
> header or source file that did not have such a section without approval. I
> don't want to have RTEMS stuff added all over the
> place to save you having to have your own version in your directory.
I think this is clearly stated by:
" OS Port Maintainers (OS alphabetical order)
OS port maintainers may make changes in OS-specific directories, as
well as OS-specific portions of the build system, without approval."
My goal is to get rid of all the __rtems__ defines in shared files.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-10-10 14:36 ` [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval Joel Sherrill
@ 2017-10-11 10:53 ` Joel Sherrill
0 siblings, 0 replies; 7+ messages in thread
From: Joel Sherrill @ 2017-10-11 10:53 UTC (permalink / raw)
To: newlib
Ignore this. It was just laying around and git send-email
picked it up. It has already been discussed and merged.
On 10/10/2017 9:36 AM, Joel Sherrill wrote:
> ---
> newlib/MAINTAINERS | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
> index 6117ff4..0bd93ff 100644
> --- a/newlib/MAINTAINERS
> +++ b/newlib/MAINTAINERS
> @@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
> msp430 DJ Delorie dj@redhat.com
> Nick Clifton nickc@redhat.com
>
> + OS Port Maintainers (OS alphabetical order)
> +
> +OS port maintainers may make changes in OS-specific directories, as
> +well as OS-specific portions of the build system, without approval.
> +
> +RTEMS Joel Sherrill joel.sherrill@oarcorp.com
>
> Write After Approval
>
> @@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
> Eric Blake eblake@redhat.com
> Will Newton will.newton@linaro.org
> Sebastian Huber sebastian.huber@embedded-brains.de
> +Joel Sherrill joel.sherrill@oarcorp.com
>
--
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherrill@OARcorp.com On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35806
Support Available (256) 722-9985
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval.
2017-10-10 14:36 [PATCH 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS Joel Sherrill
@ 2017-10-10 14:36 ` Joel Sherrill
2017-10-11 10:53 ` Joel Sherrill
0 siblings, 1 reply; 7+ messages in thread
From: Joel Sherrill @ 2017-10-10 14:36 UTC (permalink / raw)
To: newlib; +Cc: Joel Sherrill
---
newlib/MAINTAINERS | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/newlib/MAINTAINERS b/newlib/MAINTAINERS
index 6117ff4..0bd93ff 100644
--- a/newlib/MAINTAINERS
+++ b/newlib/MAINTAINERS
@@ -45,6 +45,12 @@ aarch64 Richard Earnshaw richard.earnshaw@arm.com
msp430 DJ Delorie dj@redhat.com
Nick Clifton nickc@redhat.com
+ OS Port Maintainers (OS alphabetical order)
+
+OS port maintainers may make changes in OS-specific directories, as
+well as OS-specific portions of the build system, without approval.
+
+RTEMS Joel Sherrill joel.sherrill@oarcorp.com
Write After Approval
@@ -57,3 +63,4 @@ Nick Clifton nickc@redhat.com
Eric Blake eblake@redhat.com
Will Newton will.newton@linaro.org
Sebastian Huber sebastian.huber@embedded-brains.de
+Joel Sherrill joel.sherrill@oarcorp.com
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-10 14:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 19:31 [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval Joel Sherrill
2017-06-14 8:50 ` Corinna Vinschen
2017-06-14 15:49 ` Jeff Johnston
2017-06-14 16:07 ` Joel Sherrill
2017-06-22 8:06 ` Sebastian Huber
2017-10-10 14:36 [PATCH 1/2] newlib/configure.host: Remove obsolete definition of _I386MACH_ALLOW_HW_INTERRUPTS Joel Sherrill
2017-10-10 14:36 ` [PATCH] newlib/MAINTAINERS: Add OS maintainers section and myself for RTEMS and Write After Approval Joel Sherrill
2017-10-11 10:53 ` Joel Sherrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).