* [PATCH] Amend fallback comment to work with newer gcc
@ 2020-01-27 7:26 Siddhesh Poyarekar
2020-01-27 8:11 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Siddhesh Poyarekar @ 2020-01-27 7:26 UTC (permalink / raw)
To: systemtap
Newer gcc does not recognize the fallthrough comment due to the text
following the fallthrough keyword. The "see above" doesn't seem too
valuable, so this patch drops it to fix the build.
---
runtime/unwind/unwind.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/runtime/unwind/unwind.h b/runtime/unwind/unwind.h
index e5a5921ed..7fbe7cc61 100644
--- a/runtime/unwind/unwind.h
+++ b/runtime/unwind/unwind.h
@@ -160,7 +160,7 @@ static unsigned long read_ptr_sect(const u8 **pLoc, const void *end,
#else
BUILD_BUG_ON(sizeof(u32) != sizeof(value));
#endif
- /* fallthrough, see above. */
+ /* fallthrough */
case DW_EH_PE_absptr:
if (compat_task)
{
--
2.24.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Amend fallback comment to work with newer gcc
2020-01-27 7:26 [PATCH] Amend fallback comment to work with newer gcc Siddhesh Poyarekar
@ 2020-01-27 8:11 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2020-01-27 8:11 UTC (permalink / raw)
To: Siddhesh Poyarekar, systemtap
Hi Siddhesh,
On Mon, 2020-01-27 at 12:56 +0530, Siddhesh Poyarekar wrote:
> Newer gcc does not recognize the fallthrough comment due to the text
> following the fallthrough keyword. The "see above" doesn't seem too
> valuable, so this patch drops it to fix the build.
Thanks. Pushed.
I am slightly surprised gcc made this stricter. But this is more
consistent. This was the only place in the code base where we didn't
use the bare /* fallthrough */ comment.
Cheers,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-27 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 7:26 [PATCH] Amend fallback comment to work with newer gcc Siddhesh Poyarekar
2020-01-27 8:11 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).