* [Bug releng/29668] New: The make rpm target broken
@ 2022-10-11 12:14 mcermak at redhat dot com
2022-10-11 14:43 ` [Bug releng/29668] " mcermak at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: mcermak at redhat dot com @ 2022-10-11 12:14 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=29668
Bug ID: 29668
Summary: The make rpm target broken
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: releng
Assignee: systemtap at sourceware dot org
Reporter: mcermak at redhat dot com
Target Milestone: ---
Created attachment 14392
--> https://sourceware.org/bugzilla/attachment.cgi?id=14392&action=edit
possible patch
The recent git_version related updates (a73db1bdee, 2899dcf6a5) break the `make
rpm` target. Thing is that git_version.sh doesn't find a git repo, and
generates:
/* No git repo found, probably building from dist tarball */
#undef GIT_REPO
Which, in this case, is a false assumption implicitly causing the following
build time error:
In file included from session.cxx:25:
session.cxx: In member function 'std::string
systemtap_session::version_string()':
version.h:13:49: error: 'GIT_PRETTY_REV' was not declared in this scope
13 | (STAP_EXTRA_VERSION[0] ? STAP_EXTRA_VERSION : GIT_PRETTY_REV)
| ^~~~~~~~~~~~~~
session.cxx:492:62: note: in expansion of macro 'STAP_EXTENDED_VERSION'
492 | return string (VERSION) + "/" + elfutils_version2 + ", " +
STAP_EXTENDED_VERSION;
|
^~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:1216: stap-session.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
make[2]: *** [Makefile:2135: all-recursive] Error 1
make[2]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
make[1]: *** [Makefile:800: all] Error 2
make[1]: Leaving directory '/home/stapbuilduser/rpmbuild/BUILD/systemtap-4.8'
error: Bad exit status from /var/tmp/rpm-tmp.EAV0bE (%build)
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug releng/29668] The make rpm target broken
2022-10-11 12:14 [Bug releng/29668] New: The make rpm target broken mcermak at redhat dot com
@ 2022-10-11 14:43 ` mcermak at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: mcermak at redhat dot com @ 2022-10-11 14:43 UTC (permalink / raw)
To: systemtap
https://sourceware.org/bugzilla/show_bug.cgi?id=29668
Martin Cermak <mcermak at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Martin Cermak <mcermak at redhat dot com> ---
Fixed in commit 8718a929aec6a815f0d61a4387ae74d9c2bfe88b
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11 12:14 [Bug releng/29668] New: The make rpm target broken mcermak at redhat dot com
2022-10-11 14:43 ` [Bug releng/29668] " mcermak at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).