public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Nelson Chu <nelson@rivosinc.com>,
	Kito Cheng <kito.cheng@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Cc: binutils@sourceware.org
Subject: [PATCH v2 2/3] RISC-V: Imply 'Zicsr' from 'Zkr'
Date: Wed,  7 Sep 2022 06:21:50 +0000	[thread overview]
Message-ID: <2877d646835f73c9cfb59fa6777f6b9d048499be.1662531706.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1662531706.git.research_trasio@irq.a4lg.com>

Because the 'Zkr' extension implements a CSR, seed, it requires 'Zicsr' as
a prerequisite.  On such cases, it's natural to imply required extension.

This commit adds Zkr -> Zicsr to the extension implication list.

bfd/ChangeLog:

	* elfxx-riscv.c (riscv_implicit_subsets): Imply 'Zicsr' from 'Zkr'.

gas/ChangeLog:

	* testsuite/gas/riscv/zkr.s: Separate test for the 'Zkr' extension.
	* testsuite/gas/riscv/zkr.d: Likewise.
---
 bfd/elfxx-riscv.c             |  1 +
 gas/testsuite/gas/riscv/zkr.d | 10 ++++++++++
 gas/testsuite/gas/riscv/zkr.s |  2 ++
 3 files changed, 13 insertions(+)
 create mode 100644 gas/testsuite/gas/riscv/zkr.d
 create mode 100644 gas/testsuite/gas/riscv/zkr.s

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index fb742dc9272..2e91963bbfb 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -1092,6 +1092,7 @@ static struct riscv_implicit_subset riscv_implicit_subsets[] =
   {"zkn", "zkne",	check_implicit_always},
   {"zkn", "zknd",	check_implicit_always},
   {"zkn", "zknh",	check_implicit_always},
+  {"zkr", "zicsr",	check_implicit_always},
   {"zks", "zbkb",	check_implicit_always},
   {"zks", "zbkc",	check_implicit_always},
   {"zks", "zbkx",	check_implicit_always},
diff --git a/gas/testsuite/gas/riscv/zkr.d b/gas/testsuite/gas/riscv/zkr.d
new file mode 100644
index 00000000000..4c0471835a1
--- /dev/null
+++ b/gas/testsuite/gas/riscv/zkr.d
@@ -0,0 +1,10 @@
+#as: -march=rv32i_zkr -mcsr-check
+#objdump: -d
+
+.*:[ 	]+file format .*
+
+
+Disassembly of section .text:
+
+0+000 <target>:
+[ 	]+[0-9a-f]+:[ 	]+01502573[ 	]+csrr[ 	]+a0,seed
diff --git a/gas/testsuite/gas/riscv/zkr.s b/gas/testsuite/gas/riscv/zkr.s
new file mode 100644
index 00000000000..96a38fbf49f
--- /dev/null
+++ b/gas/testsuite/gas/riscv/zkr.s
@@ -0,0 +1,2 @@
+target:
+	csrr	a0, seed
-- 
2.34.1


  parent reply	other threads:[~2022-09-07  6:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  5:53 [PATCH 0/3] RISC-V: Fix CSR accessibility and implications Tsukasa OI
2022-09-07  5:53 ` [PATCH 1/3] RISC-V: Fix vector CSR requirements and imply Tsukasa OI
2022-09-07  5:53 ` [PATCH 2/3] RISC-V: Imply 'Zicsr' from 'Zkr' Tsukasa OI
2022-09-07  5:53 ` [PATCH 3/3] RISC-V: Imply 'Zicsr' from some privileged extensions Tsukasa OI
2022-09-07  6:21 ` [PATCH v2 0/3] RISC-V: Fix CSR accessibility and implications Tsukasa OI
2022-09-07  6:21   ` [PATCH v2 1/3] RISC-V: Fix vector CSR requirements and imply Tsukasa OI
2022-09-07  9:34     ` Kito Cheng
2022-09-09 11:10       ` Tsukasa OI
2022-09-07  6:21   ` Tsukasa OI [this message]
2022-09-07  6:21   ` [PATCH v2 3/3] RISC-V: Imply 'Zicsr' from some privileged extensions Tsukasa OI
2022-09-08  6:53   ` [PATCH 0/1] RISC-V: Fix CSR accessibility on vectors Tsukasa OI
2022-09-08  6:53     ` [PATCH 1/1] RISC-V: Fix vector CSR requirements Tsukasa OI
2022-09-08  7:12       ` Nelson Chu
2022-09-08  7:15         ` Tsukasa OI
2022-09-08  7:20           ` Tsukasa OI
2022-09-07  8:49 ` [PATCH 0/3] RISC-V: Fix CSR accessibility and implications Nelson Chu
2022-09-07  9:08   ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2877d646835f73c9cfb59fa6777f6b9d048499be.1662531706.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=binutils@sourceware.org \
    --cc=kito.cheng@sifive.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).