public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@sifive.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Nelson Chu <nelson@rivosinc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Binutils <binutils@sourceware.org>
Subject: Re: [PATCH v2 1/3] RISC-V: Fix vector CSR requirements and imply
Date: Wed, 7 Sep 2022 17:34:07 +0800	[thread overview]
Message-ID: <CALLt3TjJyfrpwA7f108K+C3gp0GjM+45HXvJLfDOLQNxUCMo7g@mail.gmail.com> (raw)
In-Reply-To: <57823647ec4029f0f251835511df780d6cabcbb6.1662531706.git.research_trasio@irq.a4lg.com>

[-- Attachment #1: Type: text/plain, Size: 19738 bytes --]

I am +1 on this change, *BUT* I would like to clarify that on ISA spec
first, maybe create an issue on riscv-v-spec?

On Wed, Sep 7, 2022 at 2:22 PM Tsukasa OI <research_trasio@irq.a4lg.com>
wrote:

> Vector CSRs are also required on smaller vector subsets.  It caused
> assembler errors when only integer-only vector subextensions ('Zve32x'/
> 'Zve64x') are enabled.  It also caused warnings when CSR checking is
> enabled on subsets with floating-point arithmetic
> ('Zve32f'/'Zve64f'/'Zve64d')
>
> Not only that the most of vector CSRs are general purpose (and must be
> accessible for every vector subsets), current minimum vector subset
> 'Zve32x'
> requires fixed point arithmetic, making remaining non-general purpose
> (fixed point arithmetic only) CSRs mandatory for such subsets.
>
> So, those CSRs must be accessible from 'Zve32x', not just from 'V'.
> This commit fixes this issue which caused CSR accessibility warnings.
>
> Also, 'Zve32x' does not imply 'Zicsr' so accessing vector CSRs with
> "-march=rv32i_zve32x" does not work ('Zve64x' does not work as well).
> This commit fixes this issue by implying 'Zicsr' from 'Zve32x' ('Zve64x'
> implies 'Zve32x' so adding an implication from 'Zve32x' is sufficient).
>
> bfd/ChangeLog:
>
>         * elfxx-riscv.c (riscv_implicit_subsets): Make 'Zve32x' extension
>         to imply 'Zicsr'.
>
> gas/ChangeLog:
>
>         * config/tc-riscv.c (riscv_csr_address): Change vector CSR
>         requirement from 'V' to 'Zve32x'.
>         * testsuite/gas/riscv/csr-version-1p9p1.l: Change vector CSR
>         requirement from 'V' to 'Zve32x'.
>         * testsuite/gas/riscv/csr-version-1p10.l: Likewise.
>         * testsuite/gas/riscv/csr-version-1p11.l: Likewise.
>         * testsuite/gas/riscv/csr-version-1p12.l: Likewise.
>         * testsuite/gas/riscv/vector-csrs.s: New test.
>         * testsuite/gas/riscv/vector-csrs-zve32x.d: Likewise.
>         * testsuite/gas/riscv/vector-csrs-zve32f.d: Likewise.
>         * testsuite/gas/riscv/vector-csrs-zve64x.d: Likewise.
>         * testsuite/gas/riscv/vector-csrs-zve64f.d: Likewise.
>         * testsuite/gas/riscv/vector-csrs-zve64d.d: Likewise.
> ---
>  bfd/elfxx-riscv.c                            |  1 +
>  gas/config/tc-riscv.c                        |  2 +-
>  gas/testsuite/gas/riscv/csr-version-1p10.l   | 28 ++++++++++----------
>  gas/testsuite/gas/riscv/csr-version-1p11.l   | 28 ++++++++++----------
>  gas/testsuite/gas/riscv/csr-version-1p12.l   | 28 ++++++++++----------
>  gas/testsuite/gas/riscv/csr-version-1p9p1.l  | 28 ++++++++++----------
>  gas/testsuite/gas/riscv/vector-csrs-zve32f.d | 21 +++++++++++++++
>  gas/testsuite/gas/riscv/vector-csrs-zve32x.d | 21 +++++++++++++++
>  gas/testsuite/gas/riscv/vector-csrs-zve64d.d | 21 +++++++++++++++
>  gas/testsuite/gas/riscv/vector-csrs-zve64f.d | 21 +++++++++++++++
>  gas/testsuite/gas/riscv/vector-csrs-zve64x.d | 21 +++++++++++++++
>  gas/testsuite/gas/riscv/vector-csrs.s        | 12 +++++++++
>  12 files changed, 175 insertions(+), 57 deletions(-)
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs-zve32f.d
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs-zve32x.d
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs-zve64d.d
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs-zve64f.d
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs-zve64x.d
>  create mode 100644 gas/testsuite/gas/riscv/vector-csrs.s
>
> diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
> index 8cb3c8d4930..fb742dc9272 100644
> --- a/bfd/elfxx-riscv.c
> +++ b/bfd/elfxx-riscv.c
> @@ -1062,6 +1062,7 @@ static struct riscv_implicit_subset
> riscv_implicit_subsets[] =
>    {"zve64x", "zve32x", check_implicit_always},
>    {"zve64x", "zvl64b", check_implicit_always},
>    {"zve32x", "zvl32b", check_implicit_always},
> +  {"zve32x", "zicsr",  check_implicit_always},
>    {"zvl65536b", "zvl32768b",   check_implicit_always},
>    {"zvl32768b", "zvl16384b",   check_implicit_always},
>    {"zvl16384b", "zvl8192b",    check_implicit_always},
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index 34ce68e8252..df2e201fb74 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -935,7 +935,7 @@ riscv_csr_address (const char *csr_name,
>        extension = "zkr";
>        break;
>      case CSR_CLASS_V:
> -      extension = "v";
> +      extension = "zve32x";
>        break;
>      case CSR_CLASS_SMSTATEEN:
>      case CSR_CLASS_SMSTATEEN_AND_H:
> diff --git a/gas/testsuite/gas/riscv/csr-version-1p10.l
> b/gas/testsuite/gas/riscv/csr-version-1p10.l
> index b778453b556..999e9af1520 100644
> --- a/gas/testsuite/gas/riscv/csr-version-1p10.l
> +++ b/gas/testsuite/gas/riscv/csr-version-1p10.l
> @@ -652,20 +652,20 @@
>  .*Warning: invalid CSR `fcsr', needs `f' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vl,a1'
> -.*Warning: invalid CSR `vtype', needs `v' extension
> -.*Warning: invalid CSR `vtype', needs `v' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vtype,a1'
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vlenb,a1'
> diff --git a/gas/testsuite/gas/riscv/csr-version-1p11.l
> b/gas/testsuite/gas/riscv/csr-version-1p11.l
> index 78bae817470..a099e4ecc93 100644
> --- a/gas/testsuite/gas/riscv/csr-version-1p11.l
> +++ b/gas/testsuite/gas/riscv/csr-version-1p11.l
> @@ -650,20 +650,20 @@
>  .*Warning: invalid CSR `fcsr', needs `f' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vl,a1'
> -.*Warning: invalid CSR `vtype', needs `v' extension
> -.*Warning: invalid CSR `vtype', needs `v' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vtype,a1'
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vlenb,a1'
> diff --git a/gas/testsuite/gas/riscv/csr-version-1p12.l
> b/gas/testsuite/gas/riscv/csr-version-1p12.l
> index cb026bb55e0..cf8f2e25634 100644
> --- a/gas/testsuite/gas/riscv/csr-version-1p12.l
> +++ b/gas/testsuite/gas/riscv/csr-version-1p12.l
> @@ -532,20 +532,20 @@
>  .*Warning: invalid CSR `fcsr', needs `f' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vl,a1'
> -.*Warning: invalid CSR `vtype', needs `v' extension
> -.*Warning: invalid CSR `vtype', needs `v' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vtype,a1'
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vlenb,a1'
> diff --git a/gas/testsuite/gas/riscv/csr-version-1p9p1.l
> b/gas/testsuite/gas/riscv/csr-version-1p9p1.l
> index 4fac40fb589..5f298c1dda9 100644
> --- a/gas/testsuite/gas/riscv/csr-version-1p9p1.l
> +++ b/gas/testsuite/gas/riscv/csr-version-1p9p1.l
> @@ -678,20 +678,20 @@
>  .*Warning: invalid CSR `fcsr', needs `f' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
>  .*Warning: invalid CSR `seed', needs `zkr' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vstart', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxsat', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vxrm', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vcsr', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> -.*Warning: invalid CSR `vl', needs `v' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vstart', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxsat', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vxrm', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vcsr', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
> +.*Warning: invalid CSR `vl', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vl,a1'
> -.*Warning: invalid CSR `vtype', needs `v' extension
> -.*Warning: invalid CSR `vtype', needs `v' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
> +.*Warning: invalid CSR `vtype', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vtype,a1'
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> -.*Warning: invalid CSR `vlenb', needs `v' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
> +.*Warning: invalid CSR `vlenb', needs `zve32x' extension
>  .*Warning: read-only CSR is written `csrw vlenb,a1'
> diff --git a/gas/testsuite/gas/riscv/vector-csrs-zve32f.d
> b/gas/testsuite/gas/riscv/vector-csrs-zve32f.d
> new file mode 100644
> index 00000000000..9613915713b
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs-zve32f.d
> @@ -0,0 +1,21 @@
> +#as: -march=rv32i_zve32f -mcsr-check
> +#source: vector-csrs.s
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[      ]+[0-9a-f]+:[   ]+00802573[     ]+csrr[         ]+a0,vstart
> +[      ]+[0-9a-f]+:[   ]+00801073[     ]+csrw[         ]+vstart,zero
> +[      ]+[0-9a-f]+:[   ]+00902573[     ]+csrr[         ]+a0,vxsat
> +[      ]+[0-9a-f]+:[   ]+0090d073[     ]+csrwi[        ]+vxsat,1
> +[      ]+[0-9a-f]+:[   ]+00a02573[     ]+csrr[         ]+a0,vxrm
> +[      ]+[0-9a-f]+:[   ]+00a1d073[     ]+csrwi[        ]+vxrm,3
> +[      ]+[0-9a-f]+:[   ]+00f02573[     ]+csrr[         ]+a0,vcsr
> +[      ]+[0-9a-f]+:[   ]+00f3d073[     ]+csrwi[        ]+vcsr,7
> +[      ]+[0-9a-f]+:[   ]+c2002573[     ]+csrr[         ]+a0,vl
> +[      ]+[0-9a-f]+:[   ]+c2102573[     ]+csrr[         ]+a0,vtype
> +[      ]+[0-9a-f]+:[   ]+c2202573[     ]+csrr[         ]+a0,vlenb
> diff --git a/gas/testsuite/gas/riscv/vector-csrs-zve32x.d
> b/gas/testsuite/gas/riscv/vector-csrs-zve32x.d
> new file mode 100644
> index 00000000000..a608efbfb0b
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs-zve32x.d
> @@ -0,0 +1,21 @@
> +#as: -march=rv32i_zve32x -mcsr-check
> +#source: vector-csrs.s
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[      ]+[0-9a-f]+:[   ]+00802573[     ]+csrr[         ]+a0,vstart
> +[      ]+[0-9a-f]+:[   ]+00801073[     ]+csrw[         ]+vstart,zero
> +[      ]+[0-9a-f]+:[   ]+00902573[     ]+csrr[         ]+a0,vxsat
> +[      ]+[0-9a-f]+:[   ]+0090d073[     ]+csrwi[        ]+vxsat,1
> +[      ]+[0-9a-f]+:[   ]+00a02573[     ]+csrr[         ]+a0,vxrm
> +[      ]+[0-9a-f]+:[   ]+00a1d073[     ]+csrwi[        ]+vxrm,3
> +[      ]+[0-9a-f]+:[   ]+00f02573[     ]+csrr[         ]+a0,vcsr
> +[      ]+[0-9a-f]+:[   ]+00f3d073[     ]+csrwi[        ]+vcsr,7
> +[      ]+[0-9a-f]+:[   ]+c2002573[     ]+csrr[         ]+a0,vl
> +[      ]+[0-9a-f]+:[   ]+c2102573[     ]+csrr[         ]+a0,vtype
> +[      ]+[0-9a-f]+:[   ]+c2202573[     ]+csrr[         ]+a0,vlenb
> diff --git a/gas/testsuite/gas/riscv/vector-csrs-zve64d.d
> b/gas/testsuite/gas/riscv/vector-csrs-zve64d.d
> new file mode 100644
> index 00000000000..f42e670699a
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs-zve64d.d
> @@ -0,0 +1,21 @@
> +#as: -march=rv32i_zve64d -mcsr-check
> +#source: vector-csrs.s
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[      ]+[0-9a-f]+:[   ]+00802573[     ]+csrr[         ]+a0,vstart
> +[      ]+[0-9a-f]+:[   ]+00801073[     ]+csrw[         ]+vstart,zero
> +[      ]+[0-9a-f]+:[   ]+00902573[     ]+csrr[         ]+a0,vxsat
> +[      ]+[0-9a-f]+:[   ]+0090d073[     ]+csrwi[        ]+vxsat,1
> +[      ]+[0-9a-f]+:[   ]+00a02573[     ]+csrr[         ]+a0,vxrm
> +[      ]+[0-9a-f]+:[   ]+00a1d073[     ]+csrwi[        ]+vxrm,3
> +[      ]+[0-9a-f]+:[   ]+00f02573[     ]+csrr[         ]+a0,vcsr
> +[      ]+[0-9a-f]+:[   ]+00f3d073[     ]+csrwi[        ]+vcsr,7
> +[      ]+[0-9a-f]+:[   ]+c2002573[     ]+csrr[         ]+a0,vl
> +[      ]+[0-9a-f]+:[   ]+c2102573[     ]+csrr[         ]+a0,vtype
> +[      ]+[0-9a-f]+:[   ]+c2202573[     ]+csrr[         ]+a0,vlenb
> diff --git a/gas/testsuite/gas/riscv/vector-csrs-zve64f.d
> b/gas/testsuite/gas/riscv/vector-csrs-zve64f.d
> new file mode 100644
> index 00000000000..e88b5a3ff6e
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs-zve64f.d
> @@ -0,0 +1,21 @@
> +#as: -march=rv32i_zve64f -mcsr-check
> +#source: vector-csrs.s
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[      ]+[0-9a-f]+:[   ]+00802573[     ]+csrr[         ]+a0,vstart
> +[      ]+[0-9a-f]+:[   ]+00801073[     ]+csrw[         ]+vstart,zero
> +[      ]+[0-9a-f]+:[   ]+00902573[     ]+csrr[         ]+a0,vxsat
> +[      ]+[0-9a-f]+:[   ]+0090d073[     ]+csrwi[        ]+vxsat,1
> +[      ]+[0-9a-f]+:[   ]+00a02573[     ]+csrr[         ]+a0,vxrm
> +[      ]+[0-9a-f]+:[   ]+00a1d073[     ]+csrwi[        ]+vxrm,3
> +[      ]+[0-9a-f]+:[   ]+00f02573[     ]+csrr[         ]+a0,vcsr
> +[      ]+[0-9a-f]+:[   ]+00f3d073[     ]+csrwi[        ]+vcsr,7
> +[      ]+[0-9a-f]+:[   ]+c2002573[     ]+csrr[         ]+a0,vl
> +[      ]+[0-9a-f]+:[   ]+c2102573[     ]+csrr[         ]+a0,vtype
> +[      ]+[0-9a-f]+:[   ]+c2202573[     ]+csrr[         ]+a0,vlenb
> diff --git a/gas/testsuite/gas/riscv/vector-csrs-zve64x.d
> b/gas/testsuite/gas/riscv/vector-csrs-zve64x.d
> new file mode 100644
> index 00000000000..83aa1bba341
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs-zve64x.d
> @@ -0,0 +1,21 @@
> +#as: -march=rv32i_zve64x -mcsr-check
> +#source: vector-csrs.s
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[      ]+[0-9a-f]+:[   ]+00802573[     ]+csrr[         ]+a0,vstart
> +[      ]+[0-9a-f]+:[   ]+00801073[     ]+csrw[         ]+vstart,zero
> +[      ]+[0-9a-f]+:[   ]+00902573[     ]+csrr[         ]+a0,vxsat
> +[      ]+[0-9a-f]+:[   ]+0090d073[     ]+csrwi[        ]+vxsat,1
> +[      ]+[0-9a-f]+:[   ]+00a02573[     ]+csrr[         ]+a0,vxrm
> +[      ]+[0-9a-f]+:[   ]+00a1d073[     ]+csrwi[        ]+vxrm,3
> +[      ]+[0-9a-f]+:[   ]+00f02573[     ]+csrr[         ]+a0,vcsr
> +[      ]+[0-9a-f]+:[   ]+00f3d073[     ]+csrwi[        ]+vcsr,7
> +[      ]+[0-9a-f]+:[   ]+c2002573[     ]+csrr[         ]+a0,vl
> +[      ]+[0-9a-f]+:[   ]+c2102573[     ]+csrr[         ]+a0,vtype
> +[      ]+[0-9a-f]+:[   ]+c2202573[     ]+csrr[         ]+a0,vlenb
> diff --git a/gas/testsuite/gas/riscv/vector-csrs.s
> b/gas/testsuite/gas/riscv/vector-csrs.s
> new file mode 100644
> index 00000000000..7019a0588ef
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/vector-csrs.s
> @@ -0,0 +1,12 @@
> +target:
> +       csrr    a0, vstart
> +       csrw    vstart, zero
> +       csrr    a0, vxsat
> +       csrwi   vxsat, 1
> +       csrr    a0, vxrm
> +       csrwi   vxrm, 3
> +       csrr    a0, vcsr
> +       csrwi   vcsr, 7
> +       csrr    a0, vl
> +       csrr    a0, vtype
> +       csrr    a0, vlenb
> --
> 2.34.1
>
>

  reply	other threads:[~2022-09-07  9:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  5:53 [PATCH 0/3] RISC-V: Fix CSR accessibility and implications Tsukasa OI
2022-09-07  5:53 ` [PATCH 1/3] RISC-V: Fix vector CSR requirements and imply Tsukasa OI
2022-09-07  5:53 ` [PATCH 2/3] RISC-V: Imply 'Zicsr' from 'Zkr' Tsukasa OI
2022-09-07  5:53 ` [PATCH 3/3] RISC-V: Imply 'Zicsr' from some privileged extensions Tsukasa OI
2022-09-07  6:21 ` [PATCH v2 0/3] RISC-V: Fix CSR accessibility and implications Tsukasa OI
2022-09-07  6:21   ` [PATCH v2 1/3] RISC-V: Fix vector CSR requirements and imply Tsukasa OI
2022-09-07  9:34     ` Kito Cheng [this message]
2022-09-09 11:10       ` Tsukasa OI
2022-09-07  6:21   ` [PATCH v2 2/3] RISC-V: Imply 'Zicsr' from 'Zkr' Tsukasa OI
2022-09-07  6:21   ` [PATCH v2 3/3] RISC-V: Imply 'Zicsr' from some privileged extensions Tsukasa OI
2022-09-08  6:53   ` [PATCH 0/1] RISC-V: Fix CSR accessibility on vectors Tsukasa OI
2022-09-08  6:53     ` [PATCH 1/1] RISC-V: Fix vector CSR requirements Tsukasa OI
2022-09-08  7:12       ` Nelson Chu
2022-09-08  7:15         ` Tsukasa OI
2022-09-08  7:20           ` Tsukasa OI
2022-09-07  8:49 ` [PATCH 0/3] RISC-V: Fix CSR accessibility and implications Nelson Chu
2022-09-07  9:08   ` Tsukasa OI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALLt3TjJyfrpwA7f108K+C3gp0GjM+45HXvJLfDOLQNxUCMo7g@mail.gmail.com \
    --to=kito.cheng@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).