* [PATCH] LoongArch: Fix a bug of getting relocation type
@ 2024-01-26 3:39 mengqinggang
2024-01-26 9:01 ` mengqinggang
0 siblings, 1 reply; 8+ messages in thread
From: mengqinggang @ 2024-01-26 3:39 UTC (permalink / raw)
To: binutils
Cc: xuchenghua, chenglulu, liuzhensong, cailulu, xry111, i.swmail,
maskray, luweining, wanglei, hejinyang, mengqinggang
The old code works because R_LARCH_RELAX has no symbol index. It causes
'(rel + 1)->r_info == R_LARCH_RELAX' is 1 and ELFNN_R_TYPE (1) is 1.
---
bfd/elfnn-loongarch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index b2caa5fc3e1..0cc6273726c 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -4166,7 +4166,7 @@ loongarch_relax_tls_le (bfd *abfd, asection *sec,
static uint32_t insn_rj,insn_rd;
symval = symval - elf_hash_table (link_info)->tls_sec->vma;
/* Whether the symbol offset is in the interval (offset < 0x800). */
- if (ELFNN_R_TYPE ((rel + 1)->r_info == R_LARCH_RELAX) && (symval < 0x800))
+ if (ELFNN_R_TYPE ((rel + 1)->r_info) == R_LARCH_RELAX && (symval < 0x800))
{
switch (ELFNN_R_TYPE (rel->r_info))
{
--
2.36.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-26 3:39 [PATCH] LoongArch: Fix a bug of getting relocation type mengqinggang
@ 2024-01-26 9:01 ` mengqinggang
2024-01-26 10:55 ` Nick Clifton
0 siblings, 1 reply; 8+ messages in thread
From: mengqinggang @ 2024-01-26 9:01 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
Hi Nick,
This patch and
969f5c0e1 LoongArch: gas: Add support for s9 register
a0aa6f4ab LoongArch: ld: Add support for TLS LE symbol with addend
need to apply to 2.42 branch.
在 2024/1/26 上午11:39, mengqinggang 写道:
> The old code works because R_LARCH_RELAX has no symbol index. It causes
> '(rel + 1)->r_info == R_LARCH_RELAX' is 1 and ELFNN_R_TYPE (1) is 1.
> ---
> bfd/elfnn-loongarch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> index b2caa5fc3e1..0cc6273726c 100644
> --- a/bfd/elfnn-loongarch.c
> +++ b/bfd/elfnn-loongarch.c
> @@ -4166,7 +4166,7 @@ loongarch_relax_tls_le (bfd *abfd, asection *sec,
> static uint32_t insn_rj,insn_rd;
> symval = symval - elf_hash_table (link_info)->tls_sec->vma;
> /* Whether the symbol offset is in the interval (offset < 0x800). */
> - if (ELFNN_R_TYPE ((rel + 1)->r_info == R_LARCH_RELAX) && (symval < 0x800))
> + if (ELFNN_R_TYPE ((rel + 1)->r_info) == R_LARCH_RELAX && (symval < 0x800))
> {
> switch (ELFNN_R_TYPE (rel->r_info))
> {
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-26 9:01 ` mengqinggang
@ 2024-01-26 10:55 ` Nick Clifton
2024-01-26 11:02 ` Xi Ruoyao
0 siblings, 1 reply; 8+ messages in thread
From: Nick Clifton @ 2024-01-26 10:55 UTC (permalink / raw)
To: mengqinggang; +Cc: binutils
Hi mengqinggang,
> This patch and
>
> 969f5c0e1 LoongArch: gas: Add support for s9 register
> a0aa6f4ab LoongArch: ld: Add support for TLS LE symbol with addend
>
> need to apply to 2.42 branch.
Applied.
I am hoping that this is the last of these as I am planning on creating the
release on Monday, and I am always worried that last minute changes will
bring in new bugs rather than fix old ones...
Cheers
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-26 10:55 ` Nick Clifton
@ 2024-01-26 11:02 ` Xi Ruoyao
2024-01-26 11:41 ` Nick Clifton
2024-01-27 13:37 ` Lulu Cai
0 siblings, 2 replies; 8+ messages in thread
From: Xi Ruoyao @ 2024-01-26 11:02 UTC (permalink / raw)
To: Nick Clifton, mengqinggang; +Cc: binutils
On Fri, 2024-01-26 at 10:55 +0000, Nick Clifton wrote:
> Hi mengqinggang,
>
> > This patch and
> >
> > 969f5c0e1 LoongArch: gas: Add support for s9 register
> > a0aa6f4ab LoongArch: ld: Add support for TLS LE symbol with addend
> >
> > need to apply to 2.42 branch.
>
> Applied.
>
> I am hoping that this is the last of these as I am planning on creating the
> release on Monday, and I am always worried that last minute changes will
> bring in new bugs rather than fix old ones...
Pity that we still have the __thread vs. -mcmodel=extreme issue
(https://sourceware.org/pipermail/binutils/2024-January/132120.html and
all the following discussion) not resolved yet.
Possible to apply my straightforward (stupid) "fix" for 2.42 if a proper
fix cannot be made soon?
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-26 11:02 ` Xi Ruoyao
@ 2024-01-26 11:41 ` Nick Clifton
2024-01-27 13:37 ` Lulu Cai
1 sibling, 0 replies; 8+ messages in thread
From: Nick Clifton @ 2024-01-26 11:41 UTC (permalink / raw)
To: Xi Ruoyao, mengqinggang; +Cc: binutils
Hi Xi,
>> I am hoping that this is the last of these as I am planning on creating the
>> release on Monday, and I am always worried that last minute changes will
>> bring in new bugs rather than fix old ones...
>
> Pity that we still have the __thread vs. -mcmodel=extreme issue
> (https://sourceware.org/pipermail/binutils/2024-January/132120.html and
> all the following discussion) not resolved yet.
>
> Possible to apply my straightforward (stupid) "fix" for 2.42 if a proper
> fix cannot be made soon?
Yes. Please let me know, before Monday, which patch you want to use.
Cheers
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-26 11:02 ` Xi Ruoyao
2024-01-26 11:41 ` Nick Clifton
@ 2024-01-27 13:37 ` Lulu Cai
2024-01-28 4:14 ` lulu Tsai
1 sibling, 1 reply; 8+ messages in thread
From: Lulu Cai @ 2024-01-27 13:37 UTC (permalink / raw)
To: Nick Clifton; +Cc: Xi Ruoyao, mengqinggang, binutils
On 1/26/24 7:02 PM, Xi Ruoyao wrote:
> On Fri, 2024-01-26 at 10:55 +0000, Nick Clifton wrote:
>> Hi mengqinggang,
>>
>>> This patch and
>>>
>>> 969f5c0e1 LoongArch: gas: Add support for s9 register
>>> a0aa6f4ab LoongArch: ld: Add support for TLS LE symbol with addend
>>>
>>> need to apply to 2.42 branch.
>> Applied.
>>
>> I am hoping that this is the last of these as I am planning on creating the
>> release on Monday, and I am always worried that last minute changes will
>> bring in new bugs rather than fix old ones...
> Pity that we still have the __thread vs. -mcmodel=extreme issue
> (https://sourceware.org/pipermail/binutils/2024-January/132120.html and
> all the following discussion) not resolved yet.
>
> Possible to apply my straightforward (stupid) "fix" for 2.42 if a proper
> fix cannot be made soon?
>
Hi,
We have sent a new patch to fix the incorrect type transition problem
caused by -mcmodel=extreme.
Now only TLS type transition will be performed for normal.
[PATCH 1/2] LoongArch: Fix incorrect type transition under extreme cmodel
[PATCH 2/2] LoongArch: update test cases about TLS
Can you help us merge it into the 2.42 branch?
Thanks.
Related discussions:
[PATCH] LoongArch: Disallow TLS transition when a section contains
TLS_IE64 or TLS_DESC64 reloc
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-27 13:37 ` Lulu Cai
@ 2024-01-28 4:14 ` lulu Tsai
2024-01-29 11:24 ` Nick Clifton
0 siblings, 1 reply; 8+ messages in thread
From: lulu Tsai @ 2024-01-28 4:14 UTC (permalink / raw)
To: Nick Clifton; +Cc: Xi Ruoyao, mengqinggang, binutils
On 1/27/2024 9:37 PM, Lulu Cai wrote:
> On 1/26/24 7:02 PM, Xi Ruoyao wrote:
>> On Fri, 2024-01-26 at 10:55 +0000, Nick Clifton wrote:
>>> Hi mengqinggang,
>>>
>>>> This patch and
>>>>
>>>> 969f5c0e1 LoongArch: gas: Add support for s9 register
>>>> a0aa6f4ab LoongArch: ld: Add support for TLS LE symbol with
>>>> addend
>>>>
>>>> need to apply to 2.42 branch.
>>> Applied.
>>>
>>> I am hoping that this is the last of these as I am planning on
>>> creating the
>>> release on Monday, and I am always worried that last minute changes
>>> will
>>> bring in new bugs rather than fix old ones...
>> Pity that we still have the __thread vs. -mcmodel=extreme issue
>> (https://sourceware.org/pipermail/binutils/2024-January/132120.html and
>> all the following discussion) not resolved yet.
>>
>> Possible to apply my straightforward (stupid) "fix" for 2.42 if a proper
>> fix cannot be made soon?
>>
>
> Hi,
> We have sent a new patch to fix the incorrect type transition problem
> caused by -mcmodel=extreme.
> Now only TLS type transition will be performed for normal.
> [PATCH 1/2] LoongArch: Fix incorrect type transition under extreme cmodel
> [PATCH 2/2] LoongArch: update test cases about TLS
>
Here is a link to the relevant patch.
https://sourceware.org/pipermail/binutils/2024-January/132194.html
https://sourceware.org/pipermail/binutils/2024-January/132195.html
> Can you help us merge it into the 2.42 branch?
> Thanks.
>
> Related discussions:
> [PATCH] LoongArch: Disallow TLS transition when a section contains
> TLS_IE64 or TLS_DESC64 reloc
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] LoongArch: Fix a bug of getting relocation type
2024-01-28 4:14 ` lulu Tsai
@ 2024-01-29 11:24 ` Nick Clifton
0 siblings, 0 replies; 8+ messages in thread
From: Nick Clifton @ 2024-01-29 11:24 UTC (permalink / raw)
To: lulu Tsai; +Cc: Xi Ruoyao, mengqinggang, binutils
Hi lulu Tsai,
> Here is a link to the relevant patch.
>
> https://sourceware.org/pipermail/binutils/2024-January/132194.html
> https://sourceware.org/pipermail/binutils/2024-January/132195.html
Thanks for the links. Both of these patches are now in the 2.42 branch. Just in time! :-)
Cheers
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-29 11:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-26 3:39 [PATCH] LoongArch: Fix a bug of getting relocation type mengqinggang
2024-01-26 9:01 ` mengqinggang
2024-01-26 10:55 ` Nick Clifton
2024-01-26 11:02 ` Xi Ruoyao
2024-01-26 11:41 ` Nick Clifton
2024-01-27 13:37 ` Lulu Cai
2024-01-28 4:14 ` lulu Tsai
2024-01-29 11:24 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).