From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
binutils@sourceware.org, christoph.muellner@vrull.eu,
kito.cheng@sifive.com, nelson@rivosinc.com
Subject: Re: [RFC PATCH v1] RISC-V: Support Zicond extension
Date: Tue, 27 Jun 2023 07:32:57 -0700 [thread overview]
Message-ID: <CAAeLtUB26mHeN8_FLBzE4wtMxKOknWZjb2nGSmZnLWmj9KBj2Q@mail.gmail.com> (raw)
In-Reply-To: <d2f6c4ee-9b07-0c1d-eff1-3a3288868647@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
Thanks for taking care of this.
I had v2 in the queue for this week—even better if it took care of itself.
The updated GCC patches should go out right after the final (incorporating
comments from the public review) specification goes out.
Philipp.
On Tue 27. Jun 2023 at 06:27, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 6/20/23 22:38, Palmer Dabbelt wrote:
> > On Tue, 20 Jun 2023 21:25:12 PDT (-0700), binutils@sourceware.org wrote:
> >>
> >>
> >> On 6/19/23 08:21, Philipp Tomsich wrote:
> >>> Given that the 2.41 milestone is approaching and Zicond has passed the
> >>> FREEZE milestone (and is even out of public review already), I would
> >>> like to move this forward.
> >>> Is this OK for trunk? Should I resubmit with an updated commit
> message?
> >> Given they were acked with "this is fine to go forward with the spec
> >> freezes", I think they can go forward now. I think you just need to
> >> fixup the ChangeLog a bit since it references
> >> INSN_CLASS_XVENTANACONDOPS ;-)
> >
> > Can whomever (IIRC Philipp?) sent the first version just send a v2 with
> > the various bits fixed up (ie, no RFC, no "don't merge this" header, and
> > the review comments addressed)? That way there's a chance folks will
> > actually look at it.
> Seems a bit silly to keep deferring this. I went ahead and fixed up the
> ChangeLog entry to reference INSN_CLASS_ZICOND rather than
> INSN_CLASS_XVENTANACONDOPS as well as the spec URL and version number
> and pushed the result.
>
> Jeff
>
next prev parent reply other threads:[~2023-06-27 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 0:29 Philipp Tomsich
2023-01-26 0:26 ` Jeff Law
2023-01-26 1:02 ` Andrew Waterman
2023-03-01 1:58 ` Nelson Chu
2023-03-01 2:03 ` Palmer Dabbelt
2023-06-19 14:21 ` Philipp Tomsich
2023-06-21 4:25 ` Jeff Law
2023-06-21 4:38 ` Palmer Dabbelt
2023-06-27 13:27 ` Jeff Law
2023-06-27 14:32 ` Philipp Tomsich [this message]
2023-06-27 23:12 ` Jeff Law
2023-06-27 23:33 ` Palmer Dabbelt
2023-06-27 14:48 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeLtUB26mHeN8_FLBzE4wtMxKOknWZjb2nGSmZnLWmj9KBj2Q@mail.gmail.com \
--to=philipp.tomsich@vrull.eu \
--cc=binutils@sourceware.org \
--cc=christoph.muellner@vrull.eu \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=nelson@rivosinc.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).