* [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
@ 2024-04-23 14:13 H.J. Lu
2024-04-23 15:30 ` H.J. Lu
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2024-04-23 14:13 UTC (permalink / raw)
To: binutils; +Cc: amodra
Use long with bfd_copy_private_symbol_data to fix
.../binutils/objcopy.c: In
function ‘copy_object’:
.../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare]
3383 | for (i = 0; i < symcount; i++)
| ^
on 32-bit hosts.
PR binutils/14493
* objcopy.c (copy_object): Use long with
bfd_copy_private_symbol_data.
---
binutils/objcopy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 634ebae3fc3..e8ca1374935 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
}
- for (i = 0; i < symcount; i++)
- if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
+ for (long s = 0; s < symcount; s++)
+ if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s]))
{
status = 1;
return false;
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
2024-04-23 14:13 [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts H.J. Lu
@ 2024-04-23 15:30 ` H.J. Lu
2024-04-23 23:48 ` Alan Modra
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu @ 2024-04-23 15:30 UTC (permalink / raw)
To: binutils; +Cc: amodra
On Tue, Apr 23, 2024 at 7:13 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Use long with bfd_copy_private_symbol_data to fix
>
> .../binutils/objcopy.c: In
> function ‘copy_object’:
> .../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare]
> 3383 | for (i = 0; i < symcount; i++)
> | ^
>
> on 32-bit hosts.
>
> PR binutils/14493
> * objcopy.c (copy_object): Use long with
> bfd_copy_private_symbol_data.
> ---
> binutils/objcopy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> index 634ebae3fc3..e8ca1374935 100644
> --- a/binutils/objcopy.c
> +++ b/binutils/objcopy.c
> @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
> symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
> }
>
> - for (i = 0; i < symcount; i++)
> - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
> + for (long s = 0; s < symcount; s++)
> + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s]))
> {
> status = 1;
> return false;
> --
> 2.44.0
>
Tested on Linux/x86-64 and Linux/i686. I am checking it in.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts
2024-04-23 15:30 ` H.J. Lu
@ 2024-04-23 23:48 ` Alan Modra
0 siblings, 0 replies; 3+ messages in thread
From: Alan Modra @ 2024-04-23 23:48 UTC (permalink / raw)
To: H.J. Lu; +Cc: binutils
On Tue, Apr 23, 2024 at 08:30:03AM -0700, H.J. Lu wrote:
> On Tue, Apr 23, 2024 at 7:13 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > Use long with bfd_copy_private_symbol_data to fix
> >
> > .../binutils/objcopy.c: In
> > function ‘copy_object’:
> > .../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare]
> > 3383 | for (i = 0; i < symcount; i++)
> > | ^
> >
> > on 32-bit hosts.
> >
> > PR binutils/14493
> > * objcopy.c (copy_object): Use long with
> > bfd_copy_private_symbol_data.
> > ---
> > binutils/objcopy.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> > index 634ebae3fc3..e8ca1374935 100644
> > --- a/binutils/objcopy.c
> > +++ b/binutils/objcopy.c
> > @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch)
> > symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount);
> > }
> >
> > - for (i = 0; i < symcount; i++)
> > - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i]))
> > + for (long s = 0; s < symcount; s++)
> > + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s]))
> > {
> > status = 1;
> > return false;
> > --
> > 2.44.0
> >
>
> Tested on Linux/x86-64 and Linux/i686. I am checking it in.
Thanks. I neglected my 32-bit --enable-targets=all build.
For anyone wondering how you can do a 32-bit build on an x86_64-linux
box, the following does the trick.
CC="gcc -m32" CXX="g++ -m32" \
~/src/binutils-gdb/configure --build=i686-linux --enable-targets=all \
--enable-gold --enable-threads --disable-gdb --disable-gdbserver --disable-sim \
--disable-readline --disable-libdecnumber --disable-libbacktrace
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-23 23:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 14:13 [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts H.J. Lu
2024-04-23 15:30 ` H.J. Lu
2024-04-23 23:48 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).