Re: [PATCH v1 4/4] aarch64: testsuite: share test utils macros and use them

["Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>]

On 04/03/2024 14:43, Andrew Carlotti wrote:
> Indeed - this is just my preference at the moment, and I don't think it should
> prevent this patch being merged (particularly since you're just homogenizing
> existing macro usage).  Plenty of other people have used the macros before you,
> and must therefore have considered them to be beneficial.

I see two main purposes of all these tests.  The first is to allow some 
cross validation with other toolchains - manually staring at individual 
opcodes is a good way to frazzle your brain.  The second is to ensure 
that we don't break things going forwards (introducing regressions).

My main concern would be if the macros make it harder to do cross 
validation.  If so, then that would be an argument against them, but as 
you say, we've already used them in multiple other tests.

R.