* strange "a la m32r" comment in cgen-dis.in
@ 2002-12-11 11:55 Doug Evans
2002-12-11 12:11 ` Frank Ch. Eigler
0 siblings, 1 reply; 3+ messages in thread
From: Doug Evans @ 2002-12-11 11:55 UTC (permalink / raw)
To: fche; +Cc: cgen, binutils
I don't understand the "possibly modified" part of this comment.
cgen-dis.in:
/* Fill in ex_info fields like read_insn would. Don't actually call
read_insn, since the incoming buffer is already read (and possibly
modified a la m32r). */
Can you elaborate?
A pointer to the place that possibly modifies the incoming buffer
is sufficient. My poor eyes can't find it.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: strange "a la m32r" comment in cgen-dis.in 2002-12-11 11:55 strange "a la m32r" comment in cgen-dis.in Doug Evans @ 2002-12-11 12:11 ` Frank Ch. Eigler 2002-12-11 12:53 ` Doug Evans 0 siblings, 1 reply; 3+ messages in thread From: Frank Ch. Eigler @ 2002-12-11 12:11 UTC (permalink / raw) To: Doug Evans; +Cc: cgen, binutils [-- Attachment #1: Type: text/plain, Size: 408 bytes --] Hi - dje wrote: > I don't understand the "possibly modified" part of this comment. > cgen-dis.in: > /* Fill in ex_info fields like read_insn would. Don't actually call > read_insn, since the incoming buffer is already read (and possibly > modified a la m32r). */ > Can you elaborate? [...] I suspect I was referring to the modifications of buf[] in cgen/cpu/m32r.opc (my_print_insn). - FChE [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: strange "a la m32r" comment in cgen-dis.in 2002-12-11 12:11 ` Frank Ch. Eigler @ 2002-12-11 12:53 ` Doug Evans 0 siblings, 0 replies; 3+ messages in thread From: Doug Evans @ 2002-12-11 12:53 UTC (permalink / raw) To: Frank Ch. Eigler; +Cc: cgen, binutils Frank Ch. Eigler writes: > Hi - > > dje wrote: > > I don't understand the "possibly modified" part of this comment. > > cgen-dis.in: > > /* Fill in ex_info fields like read_insn would. Don't actually call > > read_insn, since the incoming buffer is already read (and possibly > > modified a la m32r). */ > > Can you elaborate? [...] > > I suspect I was referring to the modifications of buf[] > in cgen/cpu/m32r.opc (my_print_insn). Ah. It's not the buffer that's modified but the pointer. This is in response to the bug created when read_insn got added. I'll clean this up. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-12-11 20:53 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2002-12-11 11:55 strange "a la m32r" comment in cgen-dis.in Doug Evans 2002-12-11 12:11 ` Frank Ch. Eigler 2002-12-11 12:53 ` Doug Evans
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).