[PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Zhenqiang Chen]

# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1321604572 -28800
# Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
# Parent  a6c68712024f406df7d2da4af377f51982615833
debug/gdb: --disable-sim for CT_GDB_CROSS.

sim was already disabled for CT_GDB_NATIVE.

Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>

diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.
--- a/scripts/build/debug/300-gdb.sh
+++ b/scripts/build/debug/300-gdb.sh
@@ -146,6 +146,7 @@
              --with-build-sysroot="${CT_SYSROOT_DIR}"    \
              --with-sysroot="${CT_SYSROOT_DIR}"          \
              --with-expat=yes                            \
+            --disable-sim                               \
              --disable-werror                            \
              "${cross_extra_config[@]}"

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 421 bytes --]

On Tuesday 22 November 2011 06:19:43 Zhenqiang Chen wrote:
> debug/gdb: --disable-sim for CT_GDB_CROSS.

because ... ?  the sim is pretty useful.

> sim was already disabled for CT_GDB_NATIVE.

not really a good reason imo as native is diff from cross setups.  you don't 
simulate the target hardware on the target hardware.  you do however simulate 
the target hardware on your host development system.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Yann E. MORIN]

Zhenqiang, All,

On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321604572 -28800
> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
> # Parent  a6c68712024f406df7d2da4af377f51982615833
> debug/gdb: --disable-sim for CT_GDB_CROSS.
> 
> sim was already disabled for CT_GDB_NATIVE.
> 
> Reviewed-by: Michael Hope
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
> 
> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.
> --- a/scripts/build/debug/300-gdb.sh
> +++ b/scripts/build/debug/300-gdb.sh
> @@ -146,6 +146,7 @@
>               --with-build-sysroot="${CT_SYSROOT_DIR}"    \
>               --with-sysroot="${CT_SYSROOT_DIR}"          \
>               --with-expat=yes                            \
> +            --disable-sim                               \
>               --disable-werror                            \
>               "${cross_extra_config[@]}"

Your mailer is mangling every patch, by adding a leading space to every
line that start with a space, so the patches do not apply cleanly. I will
be fixing that locally, no need to resend.

Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the
cross-gdb? If the build is broken for some archs, it should rather be
fixed. At least, disabling/enabling 'sim' should be a config option,
so users that want to try and/or fix it have an easy way to.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Michael Hope]

On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Zhenqiang, All,
>
> On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote:
>> # HG changeset patch
>> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
>> # Date 1321604572 -28800
>> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
>> # Parent  a6c68712024f406df7d2da4af377f51982615833
>> debug/gdb: --disable-sim for CT_GDB_CROSS.
>>
>> sim was already disabled for CT_GDB_NATIVE.
>>
>> Reviewed-by: Michael Hope
>> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>
>> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.
>> --- a/scripts/build/debug/300-gdb.sh
>> +++ b/scripts/build/debug/300-gdb.sh
>> @@ -146,6 +146,7 @@
>>               --with-build-sysroot="${CT_SYSROOT_DIR}"    \
>>               --with-sysroot="${CT_SYSROOT_DIR}"          \
>>               --with-expat=yes                            \
>> +            --disable-sim                               \
>>               --disable-werror                            \
>>               "${cross_extra_config[@]}"
>
> Your mailer is mangling every patch, by adding a leading space to every
> line that start with a space, so the patches do not apply cleanly. I will
> be fixing that locally, no need to resend.
>
> Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the
> cross-gdb? If the build is broken for some archs, it should rather be
> fixed. At least, disabling/enabling 'sim' should be a config option,
> so users that want to try and/or fix it have an easy way to.

I'd like to disable sim as it isn't useful when building for a GLIBC
target and it's one more thing to support.  ARM don't want to
distribute a binary simulator due to IP reasons which I must admit
I've never understood :)

How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead?  Disabling the
simulator is rare enough that it shouldn't be an option on it's own.

-- Michael

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Khem Raj]

On Tue, Nov 22, 2011 at 5:48 PM, Michael Hope <michael.hope@linaro.org> wrote:
> On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN
> <yann.morin.1998@anciens.enib.fr> wrote:
>> Zhenqiang, All,
>>
>> On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote:
>>> # HG changeset patch
>>> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>> # Date 1321604572 -28800
>>> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
>>> # Parent  a6c68712024f406df7d2da4af377f51982615833
>>> debug/gdb: --disable-sim for CT_GDB_CROSS.
>>>
>>> sim was already disabled for CT_GDB_NATIVE.
>>>
>>> Reviewed-by: Michael Hope
>>> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>>
>>> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.
>>> --- a/scripts/build/debug/300-gdb.sh
>>> +++ b/scripts/build/debug/300-gdb.sh
>>> @@ -146,6 +146,7 @@
>>>               --with-build-sysroot="${CT_SYSROOT_DIR}"    \
>>>               --with-sysroot="${CT_SYSROOT_DIR}"          \
>>>               --with-expat=yes                            \
>>> +            --disable-sim                               \
>>>               --disable-werror                            \
>>>               "${cross_extra_config[@]}"
>>
>> Your mailer is mangling every patch, by adding a leading space to every
>> line that start with a space, so the patches do not apply cleanly. I will
>> be fixing that locally, no need to resend.
>>
>> Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the
>> cross-gdb? If the build is broken for some archs, it should rather be
>> fixed. At least, disabling/enabling 'sim' should be a config option,
>> so users that want to try and/or fix it have an easy way to.
>
> I'd like to disable sim as it isn't useful when building for a GLIBC
> target and it's one more thing to support.  ARM don't want to
> distribute a binary simulator due to IP reasons which I must admit
> I've never understood :)
>
> How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead?  Disabling the
> simulator is rare enough that it shouldn't be an option on it's own.

disabling it for glibc and uclibc toolchains is fine however it should
be left enabled for bare metal toolchains

>
> -- Michael
>
> --
> For unsubscribe information see http://sourceware.org/lists.html#faq
>
>

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Zhenqiang Chen]

>> I'd like to disable sim as it isn't useful when building for a GLIBC
>> target and it's one more thing to support.  ARM don't want to
>> distribute a binary simulator due to IP reasons which I must admit
>> I've never understood :)
>>
>> How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead?  Disabling the
>> simulator is rare enough that it shouldn't be an option on it's own.
>
> disabling it for glibc and uclibc toolchains is fine however it should
> be left enabled for bare metal toolchains
>

I will work out a patch to add GDB_CROSS_EXTRA_CONFIG_ARRAY.

Thanks!
-Zhenqiang

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 1117 bytes --]

On Tuesday 22 November 2011 20:48:15 Michael Hope wrote:
> On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN wrote:
> > Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the
> > cross-gdb? If the build is broken for some archs, it should rather be
> > fixed. At least, disabling/enabling 'sim' should be a config option,
> > so users that want to try and/or fix it have an easy way to.
> 
> I'd like to disable sim as it isn't useful when building for a GLIBC
> target and it's one more thing to support.  ARM don't want to
> distribute a binary simulator due to IP reasons which I must admit
> I've never understood :)

that's not generally true.  it depends on the target whether the sim supports 
Linux syscalls, dynamic libraries, etc...

the Blackfin sim certainly supports not only newlib/bare metal code (which also 
includes Linux/bootloaders), but also uClibc/FDPIC/FLAT Linux user programs.  
i've seen other sims in there that support Linux userland targets.

sounds like it should be made into a config option for people to control if 
*they* don't want the sim.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS

[Yann E. MORIN]

Zhenqiang, All,

On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321604572 -28800
> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd
> # Parent  a6c68712024f406df7d2da4af377f51982615833
> debug/gdb: --disable-sim for CT_GDB_CROSS.

I've added an option to enable/disable 'sim' from the menuconfig, with the
default being 'disabled', and the prompt hidden behind the 'EXPERIMENTAL'
option (that is, only people enabling EXPERIMENTAL will be able to enable
'sim').

Applied as #7723b8457efa. Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq