* [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config
@ 2011-11-22 11:54 Zhenqiang Chen
2011-11-22 17:24 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Zhenqiang Chen @ 2011-11-22 11:54 UTC (permalink / raw)
To: yann.morin.1998; +Cc: crossgcc
# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1321523984 -28800
# Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65
# Parent 986e1c75432aad60ae3239767198c653c08c01af
binutils/binutils: Add --disable-nls config when
option "Enable nls" is not selected.
Reviewed-by: Michael Hope
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
--- a/scripts/build/binutils/binutils.sh
+++ b/scripts/build/binutils/binutils.sh
@@ -62,6 +62,8 @@
[ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
fi
+ [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
+
CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
CT_DoExecLog CFG \
@@ -72,7 +74,6 @@
--host=${CT_HOST} \
--target=${CT_TARGET} \
--prefix=${CT_PREFIX_DIR} \
- --disable-nls \
--disable-multilib \
--disable-werror \
"${extra_config[@]}" \
@@ -166,6 +167,8 @@
[ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
fi
+ [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
+
CT_DoExecLog CFG \
"${CT_SRC_DIR}/binutils-${CT_BINUTILS_VERSION}/configure" \
--build=${CT_BUILD} \
@@ -175,7 +178,6 @@
--disable-werror \
--enable-shared \
--enable-static \
- --disable-nls \
--disable-multilib \
"${extra_config[@]}" \
${CT_ARCH_WITH_FLOAT} \
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config
2011-11-22 11:54 [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config Zhenqiang Chen
@ 2011-11-22 17:24 ` Yann E. MORIN
2011-11-22 20:13 ` Michael Hope
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2011-11-22 17:24 UTC (permalink / raw)
To: crossgcc; +Cc: Zhenqiang Chen
Zhenqiang, All,
On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote:
> # HG changeset patch
> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
> # Date 1321523984 -28800
> # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65
> # Parent 986e1c75432aad60ae3239767198c653c08c01af
> binutils/binutils: Add --disable-nls config when
> option "Enable nls" is not selected.
>
> Reviewed-by: Michael Hope
> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>
> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
> --- a/scripts/build/binutils/binutils.sh
> +++ b/scripts/build/binutils/binutils.sh
> @@ -62,6 +62,8 @@
> [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> fi
>
> + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
Shoudn't we also force --enable-nls otherwise?
if [ "${CT_TOOLCHAIN_ENABLE_NLS}" = "y" ]; then
extra_config+=("--enable-nls")
else
extra_config+=("--disable-nls")
fi
Not sure what the default is (I guess enabled is, but better safe than sorry).
Otherwise, good.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config
2011-11-22 17:24 ` Yann E. MORIN
@ 2011-11-22 20:13 ` Michael Hope
2011-11-22 22:00 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Michael Hope @ 2011-11-22 20:13 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: crossgcc, Zhenqiang Chen
On Wed, Nov 23, 2011 at 6:23 AM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> Zhenqiang, All,
>
> On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote:
>> # HG changeset patch
>> # User Zhenqiang Chen <zhenqiang.chen@linaro.org>
>> # Date 1321523984 -28800
>> # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65
>> # Parent 986e1c75432aad60ae3239767198c653c08c01af
>> binutils/binutils: Add --disable-nls config when
>> option "Enable nls" is not selected.
>>
>> Reviewed-by: Michael Hope
>> Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
>>
>> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
>> --- a/scripts/build/binutils/binutils.sh
>> +++ b/scripts/build/binutils/binutils.sh
>> @@ -62,6 +62,8 @@
>> [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>> fi
>>
>> + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls")
>
> Shoudn't we also force --enable-nls otherwise?
NLS is on by default and has to be explicitly turned off using
--disable-nls. See binutils/config/nls.m4:
AC_ARG_ENABLE(nls,
[ --disable-nls do not use Native Language Support],
USE_NLS=$enableval, USE_NLS=yes)
-- Michael
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config
2011-11-22 20:13 ` Michael Hope
@ 2011-11-22 22:00 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2011-11-22 22:00 UTC (permalink / raw)
To: crossgcc; +Cc: Michael Hope, Zhenqiang Chen
Michael, Zhenqiang, All,
On Tuesday 22 November 2011 21:12:55 Michael Hope wrote:
> On Wed, Nov 23, 2011 at 6:23 AM, Yann E. MORIN
> <yann.morin.1998@anciens.enib.fr> wrote:
> > Shoudn't we also force --enable-nls otherwise?
>
> NLS is on by default and has to be explicitly turned off using
> --disable-nls. See binutils/config/nls.m4:
>
> AC_ARG_ENABLE(nls,
> [ --disable-nls do not use Native Language Support],
> USE_NLS=$enableval, USE_NLS=yes)
OK, good! Queued, then.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-22 22:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-22 11:54 [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config Zhenqiang Chen
2011-11-22 17:24 ` Yann E. MORIN
2011-11-22 20:13 ` Michael Hope
2011-11-22 22:00 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).